chrome/browser/extensions/chrome_extensions_browser_client.cc - Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extensions_browser_client.cc

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup + remove DCHECK Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc ('k') | chrome/browser/extensions/extension_messages_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extensions_browser_client.cc

diff --git a/chrome/browser/extensions/chrome_extensions_browser_client.cc b/chrome/browser/extensions/chrome_extensions_browser_client.cc

index abae1f82ca08a57617d8c126a162bb8feb5052c2..14999a8f516c068d1f99a5418e5b36c0c2a34a30 100644

--- a/chrome/browser/extensions/chrome_extensions_browser_client.cc

+++ b/chrome/browser/extensions/chrome_extensions_browser_client.cc

@@ -366,10 +366,12 @@ void ChromeExtensionsBrowserClient::AttachExtensionTaskManagerTag(

return;

case VIEW_TYPE_BACKGROUND_CONTENTS:

+ case VIEW_TYPE_EXTENSION_GUEST:

case VIEW_TYPE_PANEL:

case VIEW_TYPE_TAB_CONTENTS:

// Those types are tracked by other tags:

// BACKGROUND_CONTENTS --> task_management::BackgroundContentsTag.

+ // GUEST --> extensions::ChromeGuestViewManagerDelegate.

// PANEL --> task_management::PanelTag.

// TAB_CONTENTS --> task_management::TabContentsTag.

// These tags are created and attached to the web_contents in other