Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Side by Side Diff: chrome/browser/extensions/chrome_extensions_browser_client.cc

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup + remove DCHECK Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/chrome_extensions_browser_client.h" 5 #include "chrome/browser/extensions/chrome_extensions_browser_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/version.h" 8 #include "base/version.h"
9 #include "chrome/browser/app_mode/app_mode_utils.h" 9 #include "chrome/browser/app_mode/app_mode_utils.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 case VIEW_TYPE_EXTENSION_DIALOG: 359 case VIEW_TYPE_EXTENSION_DIALOG:
360 case VIEW_TYPE_EXTENSION_POPUP: 360 case VIEW_TYPE_EXTENSION_POPUP:
361 case VIEW_TYPE_LAUNCHER_PAGE: 361 case VIEW_TYPE_LAUNCHER_PAGE:
362 case VIEW_TYPE_VIRTUAL_KEYBOARD: 362 case VIEW_TYPE_VIRTUAL_KEYBOARD:
363 // These are the only types that are tracked by the ExtensionTag. 363 // These are the only types that are tracked by the ExtensionTag.
364 task_management::WebContentsTags::CreateForExtension(web_contents, 364 task_management::WebContentsTags::CreateForExtension(web_contents,
365 view_type); 365 view_type);
366 return; 366 return;
367 367
368 case VIEW_TYPE_BACKGROUND_CONTENTS: 368 case VIEW_TYPE_BACKGROUND_CONTENTS:
369 case VIEW_TYPE_EXTENSION_GUEST:
369 case VIEW_TYPE_PANEL: 370 case VIEW_TYPE_PANEL:
370 case VIEW_TYPE_TAB_CONTENTS: 371 case VIEW_TYPE_TAB_CONTENTS:
371 // Those types are tracked by other tags: 372 // Those types are tracked by other tags:
372 // BACKGROUND_CONTENTS --> task_management::BackgroundContentsTag. 373 // BACKGROUND_CONTENTS --> task_management::BackgroundContentsTag.
374 // GUEST --> extensions::ChromeGuestViewManagerDelegate.
373 // PANEL --> task_management::PanelTag. 375 // PANEL --> task_management::PanelTag.
374 // TAB_CONTENTS --> task_management::TabContentsTag. 376 // TAB_CONTENTS --> task_management::TabContentsTag.
375 // These tags are created and attached to the web_contents in other 377 // These tags are created and attached to the web_contents in other
376 // locations, and they must be ignored here. 378 // locations, and they must be ignored here.
377 return; 379 return;
378 380
379 case VIEW_TYPE_INVALID: 381 case VIEW_TYPE_INVALID:
380 NOTREACHED(); 382 NOTREACHED();
381 return; 383 return;
382 } 384 }
383 } 385 }
384 386
385 scoped_refptr<update_client::UpdateClient> 387 scoped_refptr<update_client::UpdateClient>
386 ChromeExtensionsBrowserClient::CreateUpdateClient( 388 ChromeExtensionsBrowserClient::CreateUpdateClient(
387 content::BrowserContext* context) { 389 content::BrowserContext* context) {
388 return update_client::UpdateClientFactory( 390 return update_client::UpdateClientFactory(
389 make_scoped_refptr(new ChromeUpdateClientConfig(context))); 391 make_scoped_refptr(new ChromeUpdateClientConfig(context)));
390 } 392 }
391 393
392 } // namespace extensions 394 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698