chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc - Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup + remove DCHECK Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_apitest.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

diff --git a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

index 93d90f4f8a006d766fe64640a3b145c238dd8b92..e588cafec538d62dea0fb8b643321c6282f414f7 100644

--- a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

+++ b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

@@ -60,6 +60,9 @@ InspectableViewsFinder::View InspectableViewsFinder::ConstructView(

case VIEW_TYPE_EXTENSION_DIALOG:

view->type = api::developer_private::VIEW_TYPE_EXTENSION_DIALOG;

break;

+ case VIEW_TYPE_EXTENSION_GUEST:

+ view->type = api::developer_private::VIEW_TYPE_EXTENSION_GUEST;

+ break;

case VIEW_TYPE_EXTENSION_POPUP:

view->type = api::developer_private::VIEW_TYPE_EXTENSION_POPUP;

break;

@@ -148,8 +151,10 @@ void InspectableViewsFinder::GetViewsForExtensionProcess(

content::WebContents* web_contents =

content::WebContents::FromRenderFrameHost(host);

ViewType host_type = GetViewType(web_contents);

- if (host_type == VIEW_TYPE_EXTENSION_POPUP ||

- host_type == VIEW_TYPE_EXTENSION_DIALOG) {

+ if (host_type == VIEW_TYPE_INVALID ||

+ host_type == VIEW_TYPE_EXTENSION_POPUP ||

+ host_type == VIEW_TYPE_EXTENSION_DIALOG ||

+ host_type == VIEW_TYPE_APP_WINDOW) {

continue;

}