chrome/browser/extensions/extension_messages_apitest.cc - Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup + remove DCHECK Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_extensions_browser_client.cc ('k') | chrome/browser/extensions/process_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_messages_apitest.cc

diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc

index 9419781fb3787d779022a3243ac8b1e5690a6b01..54c44fe85c5f782a2709aa75f63a552d291d0982 100644

--- a/chrome/browser/extensions/extension_messages_apitest.cc

+++ b/chrome/browser/extensions/extension_messages_apitest.cc

@@ -123,6 +123,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MessagingExternal) {

ASSERT_TRUE(RunExtensionTest("messaging/connect_external")) << message_;

}

+// Tests that a content script can exchange messages with a tab even if there is

+// no background page.

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MessagingNoBackground) {

+ ASSERT_TRUE(StartEmbeddedTestServer());

+ ASSERT_TRUE(RunExtensionSubtest("messaging/connect_nobackground",

+ "page_in_main_frame.html")) << message_;

// Tests that messages with event_urls are only passed to extensions with

// appropriate permissions.

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MessagingEventURL) {