Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1413493005: Update layout tests to work when smooth scrolling is enabled by default (Closed)

Created:
5 years, 1 month ago by ymalik
Modified:
5 years, 1 month ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, bokan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update layout tests to work when smooth scrolling is enabled by default This CL updates expectations for tests that expect an instant scroll such that they pass when smooth scroll is enabled. Note: - Some of the tests are re-written, but most of them apply the following change: shouldBe('scrollLeft', 'expectedScrollLeft) shouldBe('scrollTop', 'expectedScrollTop') --> shouldBecomeEqual('scrollLeft == expectedScrollLeft && scrollTop == expectedScrollTop', 'true') 'shouldBecomeEqual' waits asynchronously until the condition is true. - Some of the tests just expect a certain scroll offset and are not really testing scroll-behavior. For those tests, the scrollAnimatorEnabled setting is turned off by default. internals.settings.setScrollAnimatorEnabled(false) BUG=575 Committed: https://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f Cr-Commit-Position: refs/heads/master@{#358572}

Patch Set 1 #

Total comments: 12

Patch Set 2 : worked on nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -573 lines) Patch
M third_party/WebKit/LayoutTests/editing/input/reveal-contenteditable-on-input-vertically.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/input/reveal-edit-on-input-vertically.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/vertical-scrollbar-in-rtl.html View 4 chunks +40 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/vertical-scrollbar-in-rtl-expected.txt View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/continuous-platform-wheelevent-in-scrolling-div.html View 3 chunks +5 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html View 2 chunks +30 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble-expected.txt View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/node-event-anchor-lock.html View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-in-scrolling-div.html View 3 chunks +6 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-in-scrolling-div-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-div.html View 4 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-div-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-x-in-scrolling-page.html View 1 4 chunks +6 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html View 4 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-div-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html View 4 chunks +5 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-div.html View 4 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-div-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html View 1 4 chunks +6 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheelevent-basic.html View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheelevent-basic-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html View 1 1 chunk +37 lines, -52 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheelevent-in-scrolling-div.html View 3 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheelevent-in-scrolling-div-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html View 1 1 chunk +38 lines, -51 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html View 1 2 chunks +22 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html View 1 chunk +21 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations.html View 1 chunk +21 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html View 1 chunk +21 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations.html View 1 chunk +21 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-auto-in-overflow-auto-scrolled.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-behind-scrollbar.html View 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-behind-scrollbar-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/editor-command-scroll-page-scale.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/fixed-position-behind-scrollbar.html View 1 chunk +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/fixed-position-behind-scrollbar-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/hover-during-scroll.html View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/hover-during-scroll-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/keyboard-scroll-page-scale.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/listbox-wheel-event.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/overflow-scrollability.html View 2 chunks +25 lines, -62 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/overflow-scrollability-expected.txt View 1 chunk +8 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-prevent-default.html View 2 chunks +29 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-prevent-default-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigation/same-document-scroll-position-restore.html View 2 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigation/same-document-scroll-position-restore-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/js-test.js View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ymalik
5 years, 1 month ago (2015-11-06 16:19:18 UTC) #3
skobes
looks great overall, just a few nits https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html File third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html (right): https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html#newcode26 third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html:26: window.addEventListener("mousewheel", function ...
5 years, 1 month ago (2015-11-06 22:30:23 UTC) #4
ymalik
@skobes PTAL :) https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html File third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html (right): https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html#newcode26 third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html:26: window.addEventListener("mousewheel", function mousewheelHandler(e){}, false); On 2015/11/06 ...
5 years, 1 month ago (2015-11-07 04:22:27 UTC) #5
skobes
lgtm
5 years, 1 month ago (2015-11-08 19:21:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413493005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413493005/20001
5 years, 1 month ago (2015-11-09 07:48:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-09 08:41:26 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 08:42:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f
Cr-Commit-Position: refs/heads/master@{#358572}

Powered by Google App Engine
This is Rietveld 408576698