Update layout tests to work when smooth scrolling is enabled by default

Update layout tests to work when smooth scrolling is enabled by default

This CL updates expectations for tests that expect an instant scroll such
that they pass when smooth scroll is enabled.

Note:
- Some of the tests are re-written, but most of them apply the following change:
  shouldBe('scrollLeft', 'expectedScrollLeft)
  shouldBe('scrollTop', 'expectedScrollTop') -->
  shouldBecomeEqual('scrollLeft == expectedScrollLeft && scrollTop ==
    expectedScrollTop', 'true')
'shouldBecomeEqual' waits asynchronously until the condition is true.
- Some of the tests just expect a certain scroll offset and are not really
testing scroll-behavior. For those tests, the scrollAnimatorEnabled setting
is turned off by default.
  internals.settings.setScrollAnimatorEnabled(false)

BUG=575
Committed: https://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f
Cr-Commit-Position: refs/heads/master@{#358572}

[ymalik, 2015-11-06 16:18:58]

Description was changed from

==========
Update layout tests to work when smooth scrolling is enabled by default

This CL updates expectations for tests that expect an instant scroll such
that they pass when smooth scroll is enabled.

Note:
- Some of the tests are re-written, but most of them apply the following change:
  shouldBe('scrollLeft', 'expectedScrollLeft)
  shouldBe('scrollTop', 'expectedScrollTop') -->
  shouldBecomeEqual('scrollLeft == expectedScrollLeft && scrollTop ==
    expectedScrollTop', 'true')
'shouldBecomeEqual' waits asynchronously until the condition is true.
- Some of the tests just expect a certain scroll offset and are not really
testing scroll-behavior. For those tests, the scrollAnimatorEnabled setting
is turned off by default.
  internals.settings.setScrollAnimatorEnabled(false)

BUG=575
==========

to

==========
Update layout tests to work when smooth scrolling is enabled by default

This CL updates expectations for tests that expect an instant scroll such
that they pass when smooth scroll is enabled.

Note:
- Some of the tests are re-written, but most of them apply the following change:
  shouldBe('scrollLeft', 'expectedScrollLeft)
  shouldBe('scrollTop', 'expectedScrollTop') -->
  shouldBecomeEqual('scrollLeft == expectedScrollLeft && scrollTop ==
    expectedScrollTop', 'true')
'shouldBecomeEqual' waits asynchronously until the condition is true.
- Some of the tests just expect a certain scroll offset and are not really
testing scroll-behavior. For those tests, the scrollAnimatorEnabled setting
is turned off by default.
  internals.settings.setScrollAnimatorEnabled(false)

BUG=575
==========

[ymalik, 2015-11-06 16:18:58]

ymalik@chromium.org changed reviewers:
+ skobes@chromium.org

[skobes, 2015-11-06 22:30:23]

looks great overall, just a few nits

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
(right):

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html:26:
window.addEventListener("mousewheel", function mousewheelHandler(e){}, false);
Function name (mousewheelHandler) is not needed.

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html:29:
testScrolls = [
This can be moved to the declaration of testScrolls at the top.

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html
(right):

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html:135:
shouldBecomeEqual('scrollTopBeforeWheelEvent > suggestionList.scrollTop',
'true', finishTest)
missing ;

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt
(right):

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt:4:
FAIL document.scrollingElement.scrollTop == window.expectedScrollTop &&
document.scrollingElement.scrollLeft == window.expectedScrollLeft failed to
change to true in 0.5 seconds.
Yuck, we're expecting failure?  Can you file a bug for this if we don't already
have one?

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/resources/js-test.js (right):

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/resources/js-test.js:272: // Execute condition
every animation frame until it succeed or failureTime is reached.
"succeeds"

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/resources/js-test.js:281:
window.requestAnimationFrame(function() {
"window." is not needed

[ymalik, 2015-11-07 04:22:27]

@skobes PTAL :)

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
(right):

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html:26:
window.addEventListener("mousewheel", function mousewheelHandler(e){}, false);
On 2015/11/06 22:30:23, skobes wrote:
> Function name (mousewheelHandler) is not needed.

Done.

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html:29:
testScrolls = [
On 2015/11/06 22:30:23, skobes wrote:
> This can be moved to the declaration of testScrolls at the top.

Done.

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html
(right):

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html:135:
shouldBecomeEqual('scrollTopBeforeWheelEvent > suggestionList.scrollTop',
'true', finishTest)
On 2015/11/06 22:30:23, skobes wrote:
> missing ;

Done.

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt
(right):

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt:4:
FAIL document.scrollingElement.scrollTop == window.expectedScrollTop &&
document.scrollingElement.scrollLeft == window.expectedScrollLeft failed to
change to true in 0.5 seconds.
On 2015/11/06 22:30:23, skobes wrote:
> Yuck, we're expecting failure?  Can you file a bug for this if we don't
already
> have one?

Done. crbug.com/552694. Updated comment in test.

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/resources/js-test.js (right):

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/resources/js-test.js:272: // Execute condition
every animation frame until it succeed or failureTime is reached.
On 2015/11/06 22:30:23, skobes wrote:
> "succeeds"

Done.

https://codereview.chromium.org/1413493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/resources/js-test.js:281:
window.requestAnimationFrame(function() {
On 2015/11/06 22:30:23, skobes wrote:
> "window." is not needed

Done.

[skobes, 2015-11-08 19:21:23]

lgtm

[ymalik, 2015-11-09 07:47:58]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2015-11-09 07:48:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413493005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413493005/20001

[commit-bot: I haz the power, 2015-11-09 08:41:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-09 08:42:20]

Patchset 2 (id:??) landed as
https://crrev.com/529873b0d9581a1981717383d6066a1a9dbfa52f
Cr-Commit-Position: refs/heads/master@{#358572}