third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html - Issue 1413493005: Update layout tests to work when smooth scrolling is enabled by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html

Issue 1413493005: Update layout tests to work when smooth scrolling is enabled by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: worked on nit Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html ('k') | third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html b/third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html

index 78058fe3d799e148bc467596fdd6fbc0d22e6d79..98cf4009e60ef5b8d42931cb6f1a31a436606f21 100644

--- a/third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html

+++ b/third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html

@@ -1,6 +1,8 @@

<html>

+window.jsTestIsAsync = true;

function getCenterFor(element)

{

var rect = element.getBoundingClientRect();

@@ -23,14 +25,9 @@ function runTest()

eventSender.mouseDown();

eventSender.mouseUp();

eventSender.keyDown("downArrow");

- setTimeout(verifyScrolling, 15);

-function verifyScrolling()

debug("Scroll position is more than 0");

- shouldBe("document.scrollingElement.scrollTop > 0", "true");

- testRunner.notifyDone();

+ shouldBecomeEqual("document.scrollingElement.scrollTop > 0", "true", finishJSTest);

}

</script>