third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html - Issue 1413493005: Update layout tests to work when smooth scrolling is enabled by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html

Issue 1413493005: Update layout tests to work when smooth scrolling is enabled by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: worked on nit Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-div-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/scroll-after-click-on-tab-index.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html b/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html

index c6c6572e5af433f6e8e287e2249f3388b9a68c9f..c109a6f0742bbbb8d839efa9ce43c8afd5c8a3a4 100644

--- a/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html

+++ b/third_party/WebKit/LayoutTests/fast/events/platform-wheelevent-paging-y-in-scrolling-page.html

@@ -2,6 +2,7 @@

<head>

+ window.jsTestIsAsync = true;

var givenScrollTop = 2; // Only page is scrolled per event, regardless of this number.

var givenScrollLeft = 0;

var expectedScrollTop = 525; // Window is 800x600. Scroll 87.5% of visible.

@@ -9,11 +10,7 @@

var event;

var div;

- window.jsTestIsAsync = true;

- if (window.testRunner)

- testRunner.waitUntilDone();

- function dispatchWheelEvent()

+ function runTest()

{

document.body.addEventListener("mousewheel", mousewheelHandler, false);

@@ -22,14 +19,9 @@

eventSender.continuousMouseScrollBy(-window.givenScrollLeft, -window.givenScrollTop, true);

}

- setTimeout('checkOffsets();', 100);

- }

- function checkOffsets()

- {

- shouldBe("document.scrollingElement.scrollTop", "window.expectedScrollTop");

- shouldBe("document.scrollingElement.scrollLeft", "window.expectedScrollLeft");

- finishJSTest();

+ // This test expects failure on mac: crbug.com/552694.

+ shouldBecomeEqual("document.scrollingElement.scrollTop == window.expectedScrollTop && " +

+ "document.scrollingElement.scrollLeft == window.expectedScrollLeft", "true", finishJSTest);

}

function mousewheelHandler(e)

@@ -46,7 +38,7 @@

</script>

</head>

- <body style="margin:0" onload="setTimeout('dispatchWheelEvent();', 100)">

+ <body style="margin:0" onload="runTest()">