Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: third_party/WebKit/LayoutTests/fast/events/wheelevent-basic.html

Issue 1413493005: Update layout tests to work when smooth scrolling is enabled by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: worked on nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/events/wheelevent-basic.html
diff --git a/third_party/WebKit/LayoutTests/fast/events/wheelevent-basic.html b/third_party/WebKit/LayoutTests/fast/events/wheelevent-basic.html
index e91d4e1aa2073738150eea808a38a5be66f0c2ff..166f31d00e0ca74feceebd48cea04a6042f0431f 100644
--- a/third_party/WebKit/LayoutTests/fast/events/wheelevent-basic.html
+++ b/third_party/WebKit/LayoutTests/fast/events/wheelevent-basic.html
@@ -4,10 +4,10 @@
<link rel="help" href="http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent">
<script src="../../resources/js-test.js"></script>
<script>
+window.jsTestIsAsync = true;
+
var deltaX = 0;
var deltaY = 0;
-var expectedDeltaX;
-var expectedDeltaY;
var testDiv;
function runTest() {
@@ -26,12 +26,9 @@ function runTest() {
if (window.eventSender) {
eventSender.mouseMoveTo(testDiv.offsetLeft + 5, testDiv.offsetTop + 5);
eventSender.mouseScrollBy(-1, -2);
- expectedDeltaX = testDiv.scrollLeft;
- expectedDeltaY = testDiv.scrollTop;
- shouldBeTrue("deltaX > 0");
- shouldBe("deltaX", "expectedDeltaX");
- shouldBeTrue("deltaY > 0");
- shouldBe("deltaY", "expectedDeltaY");
+ var positive = "deltaX > 0 && deltaY > 0";
+ var correct = "deltaX == testDiv.scrollLeft && deltaY == testDiv.scrollTop";
+ shouldBecomeEqual(positive + " && " + correct , "true", finishJSTest);
} else {
debug("FAIL: This test requires window.eventSender.");
}

Powered by Google App Engine
This is Rietveld 408576698