Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1412713004: Hoist some pre-condition checks out of SVGAngle/SVGEnumeration (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hoist some pre-condition checks out of SVGAngle/SVGEnumeration This moves checking of values closer to the "DOM" part of the API. Committed: https://crrev.com/a0c40ee34f7301e0aad8e1876b6c68c9f8e7e77c Cr-Commit-Position: refs/heads/master@{#355862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -31 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAngle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAngle.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedEnumerationBase.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEnumeration.h View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEnumeration.cpp View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 2 months ago (2015-10-23 17:45:35 UTC) #3
pdr.
lgtm
5 years, 2 months ago (2015-10-23 19:43:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412713004/1
5 years, 2 months ago (2015-10-23 19:44:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 19:49:10 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 19:50:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0c40ee34f7301e0aad8e1876b6c68c9f8e7e77c
Cr-Commit-Position: refs/heads/master@{#355862}

Powered by Google App Engine
This is Rietveld 408576698