Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAngle.cpp

Issue 1412713004: Hoist some pre-condition checks out of SVGAngle/SVGEnumeration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAngle.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAngle.cpp b/third_party/WebKit/Source/core/svg/SVGAngle.cpp
index 9189ceb60d04364fda502e76b7cdd4bb09027f70..930130cef4dd0f6b5926a37727c3446126e9aca9 100644
--- a/third_party/WebKit/Source/core/svg/SVGAngle.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAngle.cpp
@@ -277,13 +277,8 @@ void SVGAngle::newValueSpecifiedUnits(SVGAngleType unitType, float valueInSpecif
m_valueInSpecifiedUnits = valueInSpecifiedUnits;
}
-void SVGAngle::convertToSpecifiedUnits(SVGAngleType unitType, ExceptionState& exceptionState)
+void SVGAngle::convertToSpecifiedUnits(SVGAngleType unitType)
{
- if (m_unitType == SVG_ANGLETYPE_UNKNOWN) {
- exceptionState.throwDOMException(NotSupportedError, "Cannot convert from unknown or invalid units.");
- return;
- }
-
if (unitType == m_unitType)
return;
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAngle.h ('k') | third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698