Hoist some pre-condition checks out of SVGAngle/SVGEnumeration

third_party/WebKit/Source/core/svg/SVGAnimatedEnumerationBase.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 11 matching lines @@
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
-
 #include "core/svg/SVGAnimatedEnumerationBase.h"
 
 #include "core/svg/SVGElement.h"
 
 namespace blink {
 
 SVGAnimatedEnumerationBase::~SVGAnimatedEnumerationBase()
 {
 }
 
 void SVGAnimatedEnumerationBase::setBaseVal(unsigned short value, ExceptionState& exceptionState)
 {
     if (this->isReadOnly()) {
         exceptionState.throwDOMException(NoModificationAllowedError, "The attribute is read-only.");
         return;
     }
 
-    baseValue()->setValue(value, exceptionState);
-    if (exceptionState.hadException())
+    if (!value) {
+        exceptionState.throwTypeError("The enumeration value provided is 0, which is not settable.");
         return;
+    }
+
+    if (value > baseValue()->maxExposedEnumValue()) {
+        exceptionState.throwTypeError("The enumeration value provided (" + String::number(value) + ") is larger than the largest allowed value (" + String::number(baseValue()->maxExposedEnumValue()) + ").");
+        return;
+    }
+
+    baseValue()->setValue(value);
 
     m_baseValueUpdated = true;
 
     ASSERT(this->attributeName() != QualifiedName::null());
     contextElement()->invalidateSVGAttributes();
     contextElement()->svgAttributeChanged(this->attributeName());
 }
 
 }