Hoist some pre-condition checks out of SVGAngle/SVGEnumeration

third_party/WebKit/Source/core/svg/SVGEnumeration.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 31 matching lines @@
     typedef std::pair<unsigned short, String> StringEntry;
     typedef Vector<StringEntry> StringEntries;
 
     // SVGEnumeration does not have a tear-off type.
     typedef void TearOffType;
     typedef unsigned short PrimitiveType;
 
     ~SVGEnumerationBase() override;
 
     unsigned short value() const { return m_value <= maxExposedEnumValue() ? m_value : 0; }
-    void setValue(unsigned short, ExceptionState&);
+    void setValue(unsigned short);
 
     // SVGPropertyBase:
     virtual PassRefPtrWillBeRawPtr<SVGEnumerationBase> clone() const = 0;
     PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const String&) const override;
 
     String valueAsString() const override;
     void setValueAsString(const String&, ExceptionState&);
 
     void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
     void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement*) override;
     float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGElement*) override;
 
     static AnimatedPropertyType classType() { return AnimatedEnumeration; }
 
-    // Ensure that |SVGAnimatedEnumerationBase::setBaseVal| is used instead of |SVGAnimatedProperty<SVGEnumerationBase>::setBaseVal|.
-    void setValue(unsigned short) { ASSERT_NOT_REACHED(); }
+    static unsigned short valueOfLastEnum(const StringEntries& entries) { return entries.last().first; }
 
-    static unsigned short valueOfLastEnum(const StringEntries& entries) { return entries.last().first; }
+    // This is the maximum value that is exposed as an IDL constant on the relevant interface.
+    unsigned short maxExposedEnumValue() const { return m_maxExposed; }
 
 protected:
     SVGEnumerationBase(unsigned short value, const StringEntries& entries, unsigned short maxExposed)
         : SVGPropertyBase(classType())
         , m_value(value)
         , m_maxExposed(maxExposed)
         , m_entries(entries)
     {
     }
 
     // This is the maximum value of all the internal enumeration values.
     // This assumes that |m_entries| are sorted.
     unsigned short maxInternalEnumValue() const { return valueOfLastEnum(m_entries); }
 
-    // This is the maximum value that is exposed as an IDL constant on the relevant interface.
-    unsigned short maxExposedEnumValue() const { return m_maxExposed; }
-
     // Used by SVGMarkerOrientEnumeration.
     virtual void notifyChange() { }
 
     unsigned short m_value;
     const unsigned short m_maxExposed;
     const StringEntries& m_entries;
 };
 typedef SVGEnumerationBase::StringEntries SVGEnumerationStringEntries;
 
 template<typename Enum> const SVGEnumerationStringEntries& getStaticStringEntries();
@@ skipping 32 matching lines @@
 protected:
     explicit SVGEnumeration(Enum newValue)
         : SVGEnumerationBase(newValue, getStaticStringEntries<Enum>(), getMaxExposedEnumValue<Enum>())
     {
     }
 };
 
 } // namespace blink
 
 #endif // SVGEnumeration_h