Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412113002: Componentize MetricsServicesManager (Closed)

Created:
5 years, 2 months ago by blundell
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, droger+watchlist_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor_metrics_services_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize MetricsServicesManager This CL componentizes MetricsServicesManager for clean integration with iOS. The file has no problematic dependencies and can be componentized as-is. BUG=508025 TBR=thestig Committed: https://crrev.com/695d61f5e317af07c313ab88b248bf59b4f2426f Cr-Commit-Position: refs/heads/master@{#355270}

Patch Set 1 #

Patch Set 2 : Self-review #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -326 lines) Patch
M chrome/browser/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/metrics/uma_session_stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process.h View 3 chunks +6 lines, -2 lines 2 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_services_manager_client.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/metrics/metrics_services_manager.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/metrics/metrics_services_manager.cc View 1 2 3 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/metrics/metrics_services_manager_client.h View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/components.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + components/metrics_services_manager.gypi View 1 1 chunk +13 lines, -13 lines 0 comments Download
A + components/metrics_services_manager/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download
A components/metrics_services_manager/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A + components/metrics_services_manager/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/metrics_services_manager/metrics_services_manager.h View 3 chunks +9 lines, -5 lines 0 comments Download
A + components/metrics_services_manager/metrics_services_manager.cc View 1 2 3 3 chunks +8 lines, -6 lines 0 comments Download
A + components/metrics_services_manager/metrics_services_manager_client.h View 1 2 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
blundell
Dependent on https://codereview.chromium.org/1411593004/
5 years, 2 months ago (2015-10-19 14:50:01 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 2 months ago (2015-10-20 16:49:21 UTC) #3
blundell
TBR=thestig for //chrome outside of //chrome/browser/metrics
5 years, 2 months ago (2015-10-21 11:10:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412113002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412113002/60001
5 years, 2 months ago (2015-10-21 11:11:20 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-21 11:26:02 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/695d61f5e317af07c313ab88b248bf59b4f2426f Cr-Commit-Position: refs/heads/master@{#355270}
5 years, 2 months ago (2015-10-21 11:27:02 UTC) #11
Lei Zhang
lgtm https://codereview.chromium.org/1412113002/diff/60001/chrome/browser/browser_process.h File chrome/browser/browser_process.h (right): https://codereview.chromium.org/1412113002/diff/60001/chrome/browser/browser_process.h#newcode73 chrome/browser/browser_process.h:73: namespace metrics_services_manager { namespace is a wee bit ...
5 years, 2 months ago (2015-10-21 14:48:44 UTC) #12
blundell
5 years, 2 months ago (2015-10-21 14:51:21 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/1412113002/diff/60001/chrome/browser/browser_...
File chrome/browser/browser_process.h (right):

https://codereview.chromium.org/1412113002/diff/60001/chrome/browser/browser_...
chrome/browser/browser_process.h:73: namespace metrics_services_manager {
On 2015/10/21 14:48:44, Lei Zhang wrote:
> namespace is a wee bit long. :-P

Yeah, it's a mouthful. metrics_services_manager::MetricsServicesManagerClient.
:P. Now we just need a factory, a delegate, and a factory builder.

Powered by Google App Engine
This is Rietveld 408576698