chrome/browser/browser_process_impl.h - Issue 1412113002: Componentize MetricsServicesManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process_impl.h

Issue 1412113002: Componentize MetricsServicesManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_metrics_services_manager

Patch Set: Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_process_impl.h

diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_process_impl.h

index 36b1a591af256a462a9aeb4633f2d8c9920ca2e1..1a0efa7735caf2d5f4e3fa7b8059c425e0b39934 100644

--- a/chrome/browser/browser_process_impl.h

+++ b/chrome/browser/browser_process_impl.h

@@ -86,7 +86,8 @@ class BrowserProcessImpl : public BrowserProcess,

// BrowserProcess implementation.

void ResourceDispatcherHostCreated() override;

void EndSession() override;

- MetricsServicesManager* GetMetricsServicesManager() override;

+ metrics_services_manager::MetricsServicesManager* GetMetricsServicesManager()

+ override;

metrics::MetricsService* metrics_service() override;

rappor::RapporService* rappor_service() override;

IOThread* io_thread() override;

@@ -176,7 +177,8 @@ class BrowserProcessImpl : public BrowserProcess,

void CacheDefaultWebClientState();

- scoped_ptr<MetricsServicesManager> metrics_services_manager_;

+ scoped_ptr<metrics_services_manager::MetricsServicesManager>

+ metrics_services_manager_;

scoped_ptr<IOThread> io_thread_;

« chrome/browser/browser_process.h ('K') | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »