Componentize MetricsServicesManager

chrome/browser/browser_process.h

Index: chrome/browser/browser_process.h
diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h
index f51269519bdc44a4298c41836de8a20ded1149d3..2ab00273659adf452ba0a8e0276de2d6d3d1ff67 100644
--- a/chrome/browser/browser_process.h
+++ b/chrome/browser/browser_process.h
@@ -28,7 +28,6 @@ class IconManager;
 class IntranetRedirectDetector;
 class IOThread;
 class MediaFileSystemRegistry;
-class MetricsServicesManager;
 class NotificationUIManager;
 class PrefRegistrySimple;
 class PrefService;
@@ -71,6 +70,10 @@ namespace metrics {
 class MetricsService;
 }
 
+namespace metrics_services_manager {

[Lei Zhang, 2015/10/21 14:48:44]

namespace is a wee bit long. :-P

[blundell, 2015/10/21 14:51:21]

Yeah, it's a mouthful. metrics_services_manager::MetricsServicesManagerClient.
:P. Now we just need a factory, a delegate, and a factory builder.

+class MetricsServicesManager;
+}
+
 namespace net {
 class URLRequestContextGetter;
 }
@@ -124,7 +127,8 @@ class BrowserProcess {
 
   // Gets the manager for the various metrics-related services, constructing it
   // if necessary.
-  virtual MetricsServicesManager* GetMetricsServicesManager() = 0;
+  virtual metrics_services_manager::MetricsServicesManager*
+  GetMetricsServicesManager() = 0;
 
   // Services: any of these getters may return NULL
   virtual metrics::MetricsService* metrics_service() = 0;