Componentize MetricsServicesManager

chrome/browser/browser_process.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This interface is for managing the global services of the application. Each
 // service is lazily created when requested the first time. The service getters
 // will return NULL if the service is not available, so callers must check for
 // this condition.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_H_
@@ skipping 10 matching lines @@
 class BackgroundModeManager;
 class CRLSetFetcher;
 class DownloadRequestLimiter;
 class DownloadStatusUpdater;
 class GLStringManager;
 class GpuModeManager;
 class IconManager;
 class IntranetRedirectDetector;
 class IOThread;
 class MediaFileSystemRegistry;
-class MetricsServicesManager;
 class NotificationUIManager;
 class PrefRegistrySimple;
 class PrefService;
 class Profile;
 class ProfileManager;
 class SafeBrowsingService;
 class StatusTray;
 class WatchDogThread;
 #if defined(ENABLE_WEBRTC)
 class WebRtcLogUploader;
@@ skipping 22 matching lines @@
 }
 
 namespace message_center {
 class MessageCenter;
 }
 
 namespace metrics {
 class MetricsService;
 }
 
+namespace metrics_services_manager {

[Lei Zhang, 2015/10/21 14:48:44]

namespace is a wee bit long. :-P

[blundell, 2015/10/21 14:51:21]

Yeah, it's a mouthful. metrics_services_manager::MetricsServicesManagerClient.
:P. Now we just need a factory, a delegate, and a factory builder.

+class MetricsServicesManager;
+}
+
 namespace net {
 class URLRequestContextGetter;
 }
 
 namespace net_log {
 class ChromeNetLog;
 }
 
 namespace network_time {
 class NetworkTimeTracker;
@@ skipping 33 matching lines @@
   virtual void ResourceDispatcherHostCreated() = 0;
 
   // Invoked when the user is logging out/shutting down. When logging off we may
   // not have enough time to do a normal shutdown. This method is invoked prior
   // to normal shutdown and saves any state that must be saved before we are
   // continue shutdown.
   virtual void EndSession() = 0;
 
   // Gets the manager for the various metrics-related services, constructing it
   // if necessary.
-  virtual MetricsServicesManager* GetMetricsServicesManager() = 0;
+  virtual metrics_services_manager::MetricsServicesManager*
+  GetMetricsServicesManager() = 0;
 
   // Services: any of these getters may return NULL
   virtual metrics::MetricsService* metrics_service() = 0;
   virtual rappor::RapporService* rappor_service() = 0;
   virtual ProfileManager* profile_manager() = 0;
   virtual PrefService* local_state() = 0;
   virtual net::URLRequestContextGetter* system_request_context() = 0;
   virtual variations::VariationsService* variations_service() = 0;
   virtual web_resource::PromoResourceService* promo_resource_service() = 0;
 
@@ skipping 121 matching lines @@
   virtual ShellIntegration::DefaultWebClientState
   CachedDefaultWebClientState() = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserProcess);
 };
 
 extern BrowserProcess* g_browser_process;
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_H_