Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 14119007: Revert 194260 "Revert 194220 "[Telemetry] Make page cyclers more..." (Closed)

Created:
7 years, 8 months ago by tonyg
Modified:
7 years, 8 months ago
Reviewers:
tonyg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194260 "Revert 194220 "[Telemetry] Make page cyclers more..." Re-landing. Should work now that a race has been fixed by r194470. > Revert 194220 "[Telemetry] Make page cyclers more telemetric." > > Caused page cycler to hang on bots. > > > [Telemetry] Make page cyclers more telemetric. > > > > This causes the page cyclers to use page_sets instead of just navigating to the > > start page and letting the pages cycle themselves. This means we'll be using > > Telemetry "properly" which will allow us to record new page sets to update the > > page cyclers and it means that page cycler page sets are interchangeable with > > other benchmarks. > > > > The page cyclers still measure the same thing as they measured previously: the > > time to load the page and perform a layout. However, they measure it differently > > now. Instead of setting a new Date().getTime() in the cookie immediately before > > navigating and then grabbing the finish Date in the onload handler, this now > > just grabs performance.now() in the onload handler. This returns the number of > > milliseconds since navigationStart where navigation start is the same as the > > immediately before navigation time marked before. I've verified locally that the > > times reported are consistent, and will monitor the bots to verify. > > > > This involved moving the serving_dirs property up from the page to the page_set. > > > > BUG=None > > TEST=All page cyclers on linux and morejs on windows > > NOTRY=True > > > > Review URL: https://codereview.chromium.org/13817009 > > TBR=tonyg@chromium.org > > Review URL: https://codereview.chromium.org/14048008 TBR=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -146 lines) Patch
M trunk/src/tools/perf/page_sets/page_cycler/alexa_us.json View 1 chunk +21 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/bloat.json View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/dhtml.json View 1 chunk +18 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/dom.json View 1 chunk +10 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/indexed_db/basic_insert.json View 1 chunk +3 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/intl1.json View 1 chunk +57 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/intl2.json View 1 chunk +31 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/morejs.json View 1 chunk +10 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/morejsnp.json View 1 chunk +10 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/moz.json View 1 chunk +42 lines, -5 lines 0 comments Download
M trunk/src/tools/perf/page_sets/page_cycler/moz2.json View 1 chunk +42 lines, -5 lines 0 comments Download
A + trunk/src/tools/perf/perf_tools/page_cycler.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/tools/perf/perf_tools/page_cycler.py View 3 chunks +127 lines, -84 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/page/page.py View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/page/page_benchmark_results.py View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/page/page_unittest.py View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tonyg
7 years, 8 months ago (2013-04-16 22:58:16 UTC) #1
tonyg
7 years, 8 months ago (2013-04-16 22:58:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r194475.

Powered by Google App Engine
This is Rietveld 408576698