|
Revert 194220 "[Telemetry] Make page cyclers more telemetric."
Caused page cycler to hang on bots.
> [Telemetry] Make page cyclers more telemetric.
>
> This causes the page cyclers to use page_sets instead of just navigating to the
> start page and letting the pages cycle themselves. This means we'll be using
> Telemetry "properly" which will allow us to record new page sets to update the
> page cyclers and it means that page cycler page sets are interchangeable with
> other benchmarks.
>
> The page cyclers still measure the same thing as they measured previously: the
> time to load the page and perform a layout. However, they measure it differently
> now. Instead of setting a new Date().getTime() in the cookie immediately before
> navigating and then grabbing the finish Date in the onload handler, this now
> just grabs performance.now() in the onload handler. This returns the number of
> milliseconds since navigationStart where navigation start is the same as the
> immediately before navigation time marked before. I've verified locally that the
> times reported are consistent, and will monitor the bots to verify.
>
> This involved moving the serving_dirs property up from the page to the page_set.
>
> BUG=None
> TEST=All page cyclers on linux and morejs on windows
> NOTRY=True
>
> Review URL: https://codereview.chromium.org/13817009
TBR=tonyg@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194260
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+147 lines, -446 lines) |
Patch |
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/alexa_us.json
|
View
|
|
1 chunk |
+5 lines, -21 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/bloat.json
|
View
|
|
1 chunk |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/dhtml.json
|
View
|
|
1 chunk |
+5 lines, -18 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/dom.json
|
View
|
|
1 chunk |
+5 lines, -10 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/indexed_db/basic_insert.json
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/intl1.json
|
View
|
|
1 chunk |
+5 lines, -57 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/intl2.json
|
View
|
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/morejs.json
|
View
|
|
1 chunk |
+5 lines, -10 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/morejsnp.json
|
View
|
|
1 chunk |
+5 lines, -10 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/moz.json
|
View
|
|
1 chunk |
+5 lines, -42 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/page_sets/page_cycler/moz2.json
|
View
|
|
1 chunk |
+5 lines, -42 lines |
0 comments
|
Download
|
 |
D |
trunk/src/tools/perf/perf_tools/page_cycler.js
|
View
|
|
1 chunk |
+0 lines, -60 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/perf/perf_tools/page_cycler.py
|
View
|
|
3 chunks |
+84 lines, -127 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/telemetry/telemetry/page/page.py
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/telemetry/telemetry/page/page_benchmark_results.py
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/tools/telemetry/telemetry/page/page_unittest.py
|
View
|
|
1 chunk |
+5 lines, -8 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|