Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 13817009: [Telemetry] Make page cyclers more telemetric. (Closed)

Created:
7 years, 8 months ago by tonyg
Modified:
7 years, 8 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Make page cyclers more telemetric. This causes the page cyclers to use page_sets instead of just navigating to the start page and letting the pages cycle themselves. This means we'll be using Telemetry "properly" which will allow us to record new page sets to update the page cyclers and it means that page cycler page sets are interchangeable with other benchmarks. The page cyclers still measure the same thing as they measured previously: the time to load the page and perform a layout. However, they measure it differently now. Instead of setting a new Date().getTime() in the cookie immediately before navigating and then grabbing the finish Date in the onload handler, this now just grabs performance.now() in the onload handler. This returns the number of milliseconds since navigationStart where navigation start is the same as the immediately before navigation time marked before. I've verified locally that the times reported are consistent, and will monitor the bots to verify. This involved moving the serving_dirs property up from the page to the page_set. BUG=None TEST=All page cyclers on linux and morejs on windows NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194220

Patch Set 1 #

Patch Set 2 : Make navigate conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -147 lines) Patch
M tools/perf/page_sets/page_cycler/alexa_us.json View 1 chunk +21 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/bloat.json View 1 chunk +2 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/dhtml.json View 1 chunk +18 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/dom.json View 1 chunk +10 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/indexed_db/basic_insert.json View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/intl1.json View 1 chunk +57 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/intl2.json View 1 chunk +31 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/morejs.json View 1 chunk +10 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/morejsnp.json View 1 chunk +10 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/moz.json View 1 chunk +42 lines, -5 lines 0 comments Download
M tools/perf/page_sets/page_cycler/moz2.json View 1 chunk +42 lines, -5 lines 0 comments Download
A tools/perf/perf_tools/page_cycler.js View 1 chunk +60 lines, -0 lines 0 comments Download
M tools/perf/perf_tools/page_cycler.py View 1 3 chunks +127 lines, -84 lines 0 comments Download
M tools/telemetry/telemetry/page/page.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/page_benchmark_results.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
This is the same code that was previously checked in and rolled back because it ...
7 years, 8 months ago (2013-04-11 23:58:25 UTC) #1
dtu
sure, lgtm
7 years, 8 months ago (2013-04-12 00:02:04 UTC) #2
tonyg
Committed patchset #2 manually as r194220 (presubmit successful).
7 years, 8 months ago (2013-04-15 20:18:09 UTC) #3
tonyg
I reverted this because it caused hangs on the bots again.
7 years, 8 months ago (2013-04-16 00:15:51 UTC) #4
tonyg
7 years, 8 months ago (2013-04-16 23:00:50 UTC) #5
Message was sent while issue was closed.
On 2013/04/16 00:15:51, tonyg wrote:
> I reverted this because it caused hangs on the bots again.

FYI, I reverted the revert. Let's try this again now that I fixed that race
condition.

Powered by Google App Engine
This is Rietveld 408576698