Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: trunk/src/tools/telemetry/telemetry/page/page_unittest.py

Issue 14119007: Revert 194260 "Revert 194220 "[Telemetry] Make page cyclers more..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/page/page_benchmark_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/telemetry/telemetry/page/page_unittest.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/page/page_unittest.py (revision 194474)
+++ trunk/src/tools/telemetry/telemetry/page/page_unittest.py (working copy)
@@ -25,11 +25,14 @@
self.assertEqual(filename, 'file.html')
def testGetUrlBaseDirAndFileForUrlBaseDir(self):
- apage = page.Page('file:///../../somedir/otherdir/file.html',
- None, # In this test, we don't need a page set.
- base_dir='basedir')
- setattr(apage, 'serving_dirs', ['../../somedir/'])
- serving_dirs, filename = apage.serving_dirs_and_file
+ ps = page_set.PageSet.FromDict({
+ 'description': 'hello',
+ 'archive_path': 'foo.wpr',
+ 'serving_dirs': ['../../somedir/'],
+ 'pages': [
+ {'url': 'file:///../../somedir/otherdir/file.html'}
+ ]}, 'basedir/')
+ serving_dirs, filename = ps[0].serving_dirs_and_file
self.assertEqual(serving_dirs, ['basedir/../../somedir/'])
self.assertEqual(filename, 'otherdir/file.html')
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/page/page_benchmark_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698