bluetooth: android: Clean up BluetoothRemoteGattServiceAndroid.

bluetooth: android: Clean up BluetoothRemoteGattServiceAndroid.

::Create returns a scoped_ptr.
Correct naming of java wrapper object.
Fix up comments.

BUG=541400
Committed: https://crrev.com/b1b153d4c95783e09d0bd6536bf2676300935d04
Cr-Commit-Position: refs/heads/master@{#356328}

[scheib, 2015-10-26 21:07:54]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2015-10-26 21:36:26]

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_android.cc (right):

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_android.cc:239:
BluetoothDevice::GattServiceMap::iterator service_iterator =
nit: can you use auto?

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_service_android.h (right):

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_service_android.h:35: static
BluetoothRemoteGattServiceAndroid* Create(
This should return a scoped_ptr :p

[scheib, 2015-10-26 21:55:47]

Thanks

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_android.cc (right):

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_android.cc:239:
BluetoothDevice::GattServiceMap::iterator service_iterator =
On 2015/10/26 21:36:26, ortuno wrote:
> nit: can you use auto?

This is a grey area. Style guide recommends being more explicit when the type
isn't as obvious.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#auto

And here it's not obvious what gatt_services_.set() returns. 

I think we should leave it explicit.

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_service_android.h (right):

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_service_android.h:35: static
BluetoothRemoteGattServiceAndroid* Create(
On 2015/10/26 21:36:26, ortuno wrote:
> This should return a scoped_ptr :p

Yes! Ok, now it does.

[ortuno, 2015-10-26 22:23:35]

lgtm

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_android.cc (right):

https://codereview.chromium.org/1411183003/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_android.cc:239:
BluetoothDevice::GattServiceMap::iterator service_iterator =
On 2015/10/26 at 21:55:47, scheib wrote:
> On 2015/10/26 21:36:26, ortuno wrote:
> > nit: can you use auto?
> 
> This is a grey area. Style guide recommends being more explicit when the type
isn't as obvious.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#auto
> 
> And here it's not obvious what gatt_services_.set() returns. 
> 
> I think we should leave it explicit.

hmm not sure how BluetoothDevice::GattServiceMap makes it more obvious. I'm ok
either way though.

[scheib, 2015-10-27 16:51:11]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-10-27 16:51:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411183003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411183003/40001

[commit-bot: I haz the power, 2015-10-27 17:48:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-27 17:49:43]

Patchset 3 (id:??) landed as
https://crrev.com/b1b153d4c95783e09d0bd6536bf2676300935d04
Cr-Commit-Position: refs/heads/master@{#356328}