bluetooth: android: Clean up BluetoothRemoteGattServiceAndroid.

device/bluetooth/bluetooth_device_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_device_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/strings/stringprintf.h"
@@ skipping 218 matching lines @@
     const jstring& instanceId,
     jobject bluetooth_gatt_service_wrapper  // Java Type:
                                             // BluetoothGattServiceWrapper
     ) {
   std::string instanceIdString =
       base::android::ConvertJavaStringToUTF8(env, instanceId);
 
   if (gatt_services_.contains(instanceIdString))
     return;
 
-  BluetoothRemoteGattServiceAndroid* service =
-      BluetoothRemoteGattServiceAndroid::Create(
-          GetAdapter(), this, bluetooth_gatt_service_wrapper, instanceIdString);
-
-  gatt_services_.set(instanceIdString,
-                     make_scoped_ptr<BluetoothGattService>(service));
+  BluetoothDevice::GattServiceMap::iterator service_iterator =

[ortuno, 2015/10/26 21:36:26]

nit: can you use auto?

[scheib, 2015/10/26 21:55:47]

This is a grey area. Style guide recommends being more explicit when the type
isn't as obvious.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#auto

And here it's not obvious what gatt_services_.set() returns. 

I think we should leave it explicit.

[ortuno, 2015/10/26 22:23:34]

hmm not sure how BluetoothDevice::GattServiceMap makes it more obvious. I'm ok
either way though.

+      gatt_services_.set(
+          instanceIdString,
+          make_scoped_ptr<BluetoothRemoteGattServiceAndroid>(
+              BluetoothRemoteGattServiceAndroid::Create(
+                  GetAdapter(), this, bluetooth_gatt_service_wrapper,
+                  instanceIdString)));
 
   FOR_EACH_OBSERVER(BluetoothAdapter::Observer, GetAdapter()->GetObservers(),
-                    GattServiceAdded(adapter_, this, service));
+                    GattServiceAdded(adapter_, this, service_iterator->second));
 }
 
 BluetoothDeviceAndroid::BluetoothDeviceAndroid(BluetoothAdapterAndroid* adapter)
     : BluetoothDevice(adapter) {}
 
 std::string BluetoothDeviceAndroid::GetDeviceName() const {
   return ConvertJavaStringToUTF8(Java_ChromeBluetoothDevice_getDeviceName(
       AttachCurrentThread(), j_device_.obj()));
 }
 
 void BluetoothDeviceAndroid::CreateGattConnectionImpl() {
   Java_ChromeBluetoothDevice_createGattConnectionImpl(
       AttachCurrentThread(), j_device_.obj(),
       base::android::GetApplicationContext());
 }
 
 void BluetoothDeviceAndroid::DisconnectGatt() {
   Java_ChromeBluetoothDevice_disconnectGatt(AttachCurrentThread(),
                                             j_device_.obj());
 }
 
 }  // namespace device