bluetooth: android: BluetoothRemoteGattCharacteristicAndroid::GetUUID.

bluetooth: android: BluetoothRemoteGattCharacteristicAndroid::GetUUID.

Java object ChromeBluetoothRemoteGattCharacteristic created as well.

BUG=545682
Committed: https://crrev.com/593a988fdef81c7679fc2b4c1e20349eb25fd5c4
Cr-Commit-Position: refs/heads/master@{#356474}

[scheib, 2015-10-26 21:08:04]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2015-10-26 22:10:09]

https://codereview.chromium.org/1422093002/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/1422093002/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_characteristic_unittest.cc:104:
EXPECT_EQ(characteristic_uuid, service->GetCharacteristics()[1]->GetUUID());
Should we test that GetCharacteristic(instance_id) returns the characteristic
with the right UUID? Also what about a test where the UUIDs are different?

[scheib, 2015-10-27 22:38:18]

https://codereview.chromium.org/1422093002/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/1422093002/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_characteristic_unittest.cc:104:
EXPECT_EQ(characteristic_uuid, service->GetCharacteristics()[1]->GetUUID());
On 2015/10/26 22:10:09, ortuno wrote:
> Should we test that GetCharacteristic(instance_id) returns the characteristic
> with the right UUID? Also what about a test where the UUIDs are different?

Done.

[ortuno, 2015-10-27 22:44:36]

lgtm

[scheib, 2015-10-27 22:48:07]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-10-27 22:50:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422093002/40001

[commit-bot: I haz the power, 2015-10-27 23:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 23:17:33]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[scheib, 2015-10-27 23:35:56]

The CQ bit was checked by scheib@chromium.org

[scheib, 2015-10-27 23:35:56]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/1422093002/#ps60001
(title: "fix non android builds")

[commit-bot: I haz the power, 2015-10-27 23:36:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422093002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422093002/60001

[commit-bot: I haz the power, 2015-10-28 01:18:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-28 01:19:52]

Patchset 4 (id:??) landed as
https://crrev.com/593a988fdef81c7679fc2b4c1e20349eb25fd5c4
Cr-Commit-Position: refs/heads/master@{#356474}