Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412963004: bluetooth: android: Implement Characteristic GetIdentifier, fix Service IDs too. (Closed)

Created:
5 years, 2 months ago by scheib
Modified:
5 years, 1 month ago
Reviewers:
ortuno, armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: android: Implement Characteristic GetIdentifier, fix Service IDs too. BluetoothGattCharacteristic::GetIdentifier is implemented. BluetoothGattService::GetIdentifier is fixed to produce an adapter unique value. BUG=545682, 546747 Committed: https://crrev.com/dd941ba40bbd76375e6fe43bb55aef55e9d3c282 Cr-Commit-Position: refs/heads/master@{#356243}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -59 lines) Patch
M device/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java View 1 chunk +4 lines, -6 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattService.java View 3 chunks +10 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_characteristic.h View 1 chunk +2 lines, -2 lines 0 comments Download
A device/bluetooth/bluetooth_gatt_characteristic_unittest.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_service_unittest.cc View 6 chunks +53 lines, -22 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_android.h View 2 chunks +6 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_android.h View 3 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_android.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1411183003 Patch 1
Issue 1411183003 Patch 20001
Issue 1411183003 Patch 40001

Messages

Total messages: 12 (5 generated)
scheib
5 years, 2 months ago (2015-10-25 01:58:59 UTC) #4
ortuno
lgtm
5 years, 1 month ago (2015-10-26 21:28:31 UTC) #5
scheib
Arman, OWNERS review of comment change for GetIdentifier.
5 years, 1 month ago (2015-10-26 21:40:57 UTC) #7
armansito
lgtm
5 years, 1 month ago (2015-10-27 03:09:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412963004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412963004/40001
5 years, 1 month ago (2015-10-27 04:27:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-10-27 05:40:18 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 05:41:51 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dd941ba40bbd76375e6fe43bb55aef55e9d3c282
Cr-Commit-Position: refs/heads/master@{#356243}

Powered by Google App Engine
This is Rietveld 408576698