Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1411043009: Fix compilation of browser_window_cocoa_unittest.mm with OS X 10.11 SDK. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation of browser_window_cocoa_unittest.mm with OS X 10.11 SDK. Fixes the following compilation error: ../../testing/gtest/include/gtest/gtest.h:1526:28: error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare] GTEST_IMPL_CMP_HELPER_(NE, !=); ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ ../../testing/gtest/include/gtest/gtest.h:1514:12: note: expanded from macro 'GTEST_IMPL_CMP_HELPER_' if (val1 op val2) {\ ~~~~ ^ ~~~~ ../../chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm:65:3: note: in instantiation of function template specialization 'testing::internal::CmpHelperNE<unsigned long, long>' requested here EXPECT_NE([bwc->WindowTitle() rangeOfString:playing_emoji].location, ^ BUG=None

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 chunk +6 lines, -6 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-06 10:49:48 UTC) #2
Scott Hess - ex-Googler
LGTM (w/eyeroll at SDK developers). https://codereview.chromium.org/1411043009/diff/1/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm File chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm (right): https://codereview.chromium.org/1411043009/diff/1/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm#newcode61 chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm:61: static_cast<NSUInteger>(NSNotFound)); EXPECT_EQ() is supposed ...
5 years, 1 month ago (2015-11-06 14:25:07 UTC) #3
sdefresne
5 years, 1 month ago (2015-11-12 09:08:33 UTC) #4
Message was sent while issue was closed.
Original CL was reverted (https://codereview.chromium.org/1412803012), closing.

Powered by Google App Engine
This is Rietveld 408576698