Componentize about_flags::FeatureEntry in flags_ui component.

Componentize about_flags::FeatureEntry in flags_ui component.

Move FeatureEntry structure definition to components/flags_ui so that
it can be shared with iOS and move the helper macros to a secondary
header file for the same reason.

Move IDS_GENERIC_EXPERIMENT_CHOICE_* strings to flags_ui.grdp.

BUG=551954
Committed: https://crrev.com/246c564da980b3dbbd0a062688ec65539b4b2c35
Cr-Commit-Position: refs/heads/master@{#359927}

[sdefresne, 2015-11-06 10:41:52]

Patchset #1 (id:1) has been deleted

[sdefresne, 2015-11-06 10:45:47]

sdefresne@chromium.org changed reviewers:
+ asvitkine@chromium.org, bauerb@chromium.org, sky@chromium.org

[sdefresne, 2015-11-06 10:45:47]

Hi all,

My end goal is to componentize most of about_flags.{cc,h} code (i.e.
FeatureEntry, FlagsState and supporting free function) so that they can be
shared with iOS. The list of all FlagEntry and the initialisation will still
live in chrome/browser/about_flags.{cc,h}.

This is the first step, moving the FeatureEntry class to flags_ui.

asvitkine: you've done some work on FeatureEntry recently, could you take a
look. droger also suggested that you could become an OWNERS of
components/flags_ui, WDYT?

bauerb: can you review as OWNERS of components/flags_ui?

sky: can you review as OWNERS of chrome/browser/about_flags.* and
chrome/browser/profiles/*

[sdefresne, 2015-11-06 10:50:21]

sdefresne@chromium.org changed reviewers:
+ avi@chromium.org

[sdefresne, 2015-11-06 10:50:21]

+avi: can you review the new DEPS on //ui/base?

[Bernhard Bauer, 2015-11-06 11:07:25]

lgtm

https://codereview.chromium.org/1415953005/diff/20001/components/flags_ui/fea...
File components/flags_ui/feature_entry.h (right):

https://codereview.chromium.org/1415953005/diff/20001/components/flags_ui/fea...
components/flags_ui/feature_entry.h:83: // Simple switches that have no value
should use "" for command_line_value.
Nit: Add an empty line before this one?

[Alexei Svitkine (slow), 2015-11-06 16:25:53]

LGTM!

I'm ok with being an OWNER of this code.

[Avi (use Gerrit), 2015-11-06 20:30:58]

lgtm

deps

[sky, 2015-11-06 21:22:46]

sky@chromium.org changed reviewers:
- sky@chromium.org

[sky, 2015-11-06 21:22:46]

sky->thakis

[sdefresne, 2015-11-12 08:59:36]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2015-11-12 08:59:36]

Nico, can you review as OWNERS of chrome/browser/about_flags.* and
chrome/browser/profiles/?

[sdefresne, 2015-11-13 09:51:34]

ping?

[sdefresne, 2015-11-16 10:17:05]

thakis: ping?

[Nico, 2015-11-16 18:53:00]

lgtm

https://codereview.chromium.org/1415953005/diff/40001/components/flags_ui/OWNERS
File components/flags_ui/OWNERS (right):

https://codereview.chromium.org/1415953005/diff/40001/components/flags_ui/OWN...
components/flags_ui/OWNERS:7: xiyuan@chromium.org
(how did you arrive at this owners file?)

[sdefresne, 2015-11-16 19:48:05]

On 2015/11/16 at 18:53:00, thakis wrote:
> lgtm
> 
>
https://codereview.chromium.org/1415953005/diff/40001/components/flags_ui/OWNERS
> File components/flags_ui/OWNERS (right):
> 
>
https://codereview.chromium.org/1415953005/diff/40001/components/flags_ui/OWN...
> components/flags_ui/OWNERS:7: xiyuan@chromium.org
> (how did you arrive at this owners file?)

//components/flags_ui started as the place were we componentized the code
corresponding to about://flags webui. The code initially came from
//chrome/browser/ui/webui and the OWNERS is a copy of
//chrome/browser/ui/webui/OWNERS. I did not participate to the creation of the
component, but asked droger@ who do it. I then added asvitkine@ as I knew he had
done recent refactoring of that code.

If you think this list of OWNERS should be changed, I'd be happy to comply in a
followup CL.

Thank you for the review.

[sdefresne, 2015-11-16 20:32:20]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-11-16 20:32:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
avi@chromium.org, asvitkine@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1415953005/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-11-16 20:35:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415953005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415953005/60001

[Nico, 2015-11-16 21:17:53]

On Mon, Nov 16, 2015 at 11:48 AM, <sdefresne@chromium.org> wrote:

> On 2015/11/16 at 18:53:00, thakis wrote:
>
>> lgtm
>>
>
>
>
>
https://codereview.chromium.org/1415953005/diff/40001/components/flags_ui/OWNERS
>
>> File components/flags_ui/OWNERS (right):
>>
>
>
>
>
https://codereview.chromium.org/1415953005/diff/40001/components/flags_ui/OWN...
>
>> components/flags_ui/OWNERS:7: xiyuan@chromium.org
>> (how did you arrive at this owners file?)
>>
>
> //components/flags_ui started as the place were we componentized the code
> corresponding to about://flags webui. The code initially came from
> //chrome/browser/ui/webui and the OWNERS is a copy of
> //chrome/browser/ui/webui/OWNERS. I did not participate to the creation of
> the
> component, but asked droger@ who do it. I then added asvitkine@ as I knew
> he had
> done recent refactoring of that code.
>
> If you think this list of OWNERS should be changed, I'd be happy to comply
> in a
> followup CL.


Nah, it's ok, I was just wondering 'cause other than asvitkine (and dbeam
and possibly bauerb I think?) I don't remember seeing many about_flags CLs
from the others. But they're all accomplished people elsewhere, so if they
feel they can review this code it's all good.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-11-16 21:47:40]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-11-16 21:49:12]

Patchset 3 (id:??) landed as
https://crrev.com/246c564da980b3dbbd0a062688ec65539b4b2c35
Cr-Commit-Position: refs/heads/master@{#359927}