Revert "Indicate in the Window menu which Chrome window has an active sound playing"

Revert "Indicate in the Window menu which Chrome window has an active sound playing"

The patch broke compilation on Mac with SDK 10.11.
In file included from ../../chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm:13:
In file included from ../../chrome/browser/ui/cocoa/cocoa_profile_test.h:9:
In file included from ../../chrome/browser/ui/cocoa/cocoa_test_helper.h:10:
In file included from ../../ui/gfx/test/ui_cocoa_test_helper.h:14:
In file included from ../../testing/platform_test.h:8:
../../testing/gtest/include/gtest/gtest.h:1392:16: error: comparison of integers of different signs: 'const unsigned long' and 'const long' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
../../testing/gtest/include/gtest/gtest.h:1422:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, long>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
../../chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm:60:3: note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<unsigned long, long>' requested here
  EXPECT_EQ([bwc->WindowTitle() rangeOfString:playing_emoji].location,
  ^

The constant NSNotFound is declared differently
10.10: enum {NSNotFound = NSIntegerMax};
10.11: static const NSInteger NSNotFound = NSIntegerMax;

This reverts commit 70d337daa152a75db530fa04214caba48ff39bd6.

R=shahriar.rostami@gmail.com
TBR=rsesek@chromium.org,miu@chromium.org

Committed: https://crrev.com/00c4dceedd23e6a98df0e7104e28f3ba257208da
Cr-Commit-Position: refs/heads/master@{#358331}

[vasilii, 2015-11-06 15:15:32]

Description was changed from

==========
Revert "Indicate in the Window menu which Chrome window has an active sound
playing"

The patch broke compilation on Mac with SDK 10.11.
In file included from
../../chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm:13:
In file included from ../../chrome/browser/ui/cocoa/cocoa_profile_test.h:9:
In file included from ../../chrome/browser/ui/cocoa/cocoa_test_helper.h:10:
In file included from ../../ui/gfx/test/ui_cocoa_test_helper.h:14:
In file included from ../../testing/platform_test.h:8:
../../testing/gtest/include/gtest/gtest.h:1392:16: error: comparison of integers
of different signs: 'const unsigned long' and 'const long'
[-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
../../testing/gtest/include/gtest/gtest.h:1422:12: note: in instantiation of
function template specialization 'testing::internal::CmpHelperEQ<unsigned long,
long>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
../../chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm:60:3: note: in
instantiation of function template specialization
'testing::internal::EqHelper<false>::Compare<unsigned long, long>' requested
here
  EXPECT_EQ([bwc->WindowTitle() rangeOfString:playing_emoji].location,
  ^

The constant NSNotFound is declared differently
10.10: enum {NSNotFound = NSIntegerMax};
10.11: static const NSInteger NSNotFound = NSIntegerMax;

This reverts commit 70d337daa152a75db530fa04214caba48ff39bd6.

R=shahriar.rostami@gmail.com
==========

to

==========
Revert "Indicate in the Window menu which Chrome window has an active sound
playing"

The patch broke compilation on Mac with SDK 10.11.
In file included from
../../chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm:13:
In file included from ../../chrome/browser/ui/cocoa/cocoa_profile_test.h:9:
In file included from ../../chrome/browser/ui/cocoa/cocoa_test_helper.h:10:
In file included from ../../ui/gfx/test/ui_cocoa_test_helper.h:14:
In file included from ../../testing/platform_test.h:8:
../../testing/gtest/include/gtest/gtest.h:1392:16: error: comparison of integers
of different signs: 'const unsigned long' and 'const long'
[-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
../../testing/gtest/include/gtest/gtest.h:1422:12: note: in instantiation of
function template specialization 'testing::internal::CmpHelperEQ<unsigned long,
long>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
../../chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm:60:3: note: in
instantiation of function template specialization
'testing::internal::EqHelper<false>::Compare<unsigned long, long>' requested
here
  EXPECT_EQ([bwc->WindowTitle() rangeOfString:playing_emoji].location,
  ^

The constant NSNotFound is declared differently
10.10: enum {NSNotFound = NSIntegerMax};
10.11: static const NSInteger NSNotFound = NSIntegerMax;

This reverts commit 70d337daa152a75db530fa04214caba48ff39bd6.

R=shahriar.rostami@gmail.com
TBR=rsesek@chromium.org,miu@chromium.org
==========

[vasilii, 2015-11-06 15:15:39]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2015-11-06 15:16:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412803012/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412803012/1

[commit-bot: I haz the power, 2015-11-06 15:59:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-06 16:00:54]

Patchset 1 (id:??) landed as
https://crrev.com/00c4dceedd23e6a98df0e7104e28f3ba257208da
Cr-Commit-Position: refs/heads/master@{#358331}

[Robert Sesek, 2015-11-09 20:51:21]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2015-11-09 20:51:22]

Was this broke on on a bot, if so which one? I don't think we should be
reverting CLs for breaking 10.11 SDK.

[vasilii, 2015-11-10 09:11:04]

On 2015/11/09 20:51:22, Robert Sesek (OOO til 23.11) wrote:
> Was this broke on on a bot, if so which one? I don't think we should be
> reverting CLs for breaking 10.11 SDK.

There is no bot. People have put an effort to make this work
(http://crbug.com/517914,
https://groups.google.com/a/chromium.org/forum/?utm_source=digest&utm_medium=...).
XCode 7 installs only the new SDK.

[sdefresne, 2015-11-12 09:08:00]

On 2015/11/10 at 09:11:04, vasilii wrote:
> On 2015/11/09 20:51:22, Robert Sesek (OOO til 23.11) wrote:
> > Was this broke on on a bot, if so which one? I don't think we should be
> > reverting CLs for breaking 10.11 SDK.
> 
> There is no bot. People have put an effort to make this work
(http://crbug.com/517914,
https://groups.google.com/a/chromium.org/forum/?utm_source=digest&utm_medium=...).
XCode 7 installs only the new SDK.

I had an approved CL to fix this: https://codereview.chromium.org/1411043009

I did not land it because I was asked to make some cosmetic changes and had to
leave for an extended weekend. It can still be integrated into a reland of the
CL.

[shahriar, 2015-11-12 17:16:18]

On 2015/11/12 09:08:00, sdefresne wrote:
> On 2015/11/10 at 09:11:04, vasilii wrote:
> > On 2015/11/09 20:51:22, Robert Sesek (OOO til 23.11) wrote:
> > > Was this broke on on a bot, if so which one? I don't think we should be
> > > reverting CLs for breaking 10.11 SDK.
> > 
> > There is no bot. People have put an effort to make this work
> (http://crbug.com/517914,
>
https://groups.google.com/a/chromium.org/forum/?utm_source=digest&utm_medium=...).
> XCode 7 installs only the new SDK.
> 
> I had an approved CL to fix this: https://codereview.chromium.org/1411043009
> 
> I did not land it because I was asked to make some cosmetic changes and had to
> leave for an extended weekend. It can still be integrated into a reland of the
> CL.


@sdefresne
I applied that cosmetic change that you got on your CL, 
and mention it on the comments that I took the idea from your CL review:

https://codereview.chromium.org/1432803002/#msg13

I'm not sure if it's ethical or not to take that review from your CL.