Fix compilation of browser_window_cocoa_unittest.mm with OS X 10.11 SDK.

chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/mac/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/fullscreen.h"
 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
@@ skipping 40 matching lines @@
 }
 
 TEST_F(BrowserWindowCocoaTest, TestWindowTitle) {
   scoped_ptr<BrowserWindowCocoa> bwc(
       new BrowserWindowCocoa(browser(), controller_));
   NSString* playing_emoji =
       l10n_util::GetNSStringF(IDS_WINDOW_AUDIO_PLAYING_MAC, base::string16());
   NSString* muting_emoji =
       l10n_util::GetNSStringF(IDS_WINDOW_AUDIO_MUTING_MAC, base::string16());
   EXPECT_EQ([bwc->WindowTitle() rangeOfString:playing_emoji].location,
-            NSNotFound);
+            static_cast<NSUInteger>(NSNotFound));

[Scott Hess - ex-Googler, 2015/11/06 14:25:07]

EXPECT_EQ() is supposed to be ordered expected, then actual.  Could you swap
these while you're here?

   EXPECT_EQ([bwc->WindowTitle() rangeOfString:muting_emoji].location,
-            NSNotFound);
+            static_cast<NSUInteger>(NSNotFound));
   bwc->UpdateMediaState(TAB_MEDIA_STATE_AUDIO_PLAYING);
   EXPECT_NE([bwc->WindowTitle() rangeOfString:playing_emoji].location,
-            NSNotFound);
+            static_cast<NSUInteger>(NSNotFound));
   bwc->UpdateMediaState(TAB_MEDIA_STATE_AUDIO_MUTING);
   EXPECT_NE([bwc->WindowTitle() rangeOfString:muting_emoji].location,
-            NSNotFound);
+            static_cast<NSUInteger>(NSNotFound));
   bwc->UpdateMediaState(TAB_MEDIA_STATE_NONE);
   EXPECT_EQ([bwc->WindowTitle() rangeOfString:playing_emoji].location,
-            NSNotFound);
+            static_cast<NSUInteger>(NSNotFound));
   EXPECT_EQ([bwc->WindowTitle() rangeOfString:muting_emoji].location,
-            NSNotFound);
+            static_cast<NSUInteger>(NSNotFound));
 }
 
 // Test that IsMaximized() returns false when the browser window goes from
 // maximized to minimized state - http://crbug/452976.
 TEST_F(BrowserWindowCocoaTest, TestMinimizeState) {
   scoped_ptr<BrowserWindowCocoa> bwc(
       new BrowserWindowCocoa(browser(), controller_));
 
   EXPECT_FALSE(bwc->IsMinimized());
   bwc->Maximize();
@@ skipping 119 matching lines @@
   [[[window_ stub] andReturn:nil] delegate];
   [[[controller_ stub] andReturn:window_] window];
   [[window_ expect] orderOut:nil];
   [[window_ expect] close];
   CreateAndCloseBrowserWindow();
   EXPECT_OCMOCK_VERIFY(controller_);
   EXPECT_OCMOCK_VERIFY(window_);
 }
 
 // TODO(???): test other methods of BrowserWindowCocoa