Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1410383011: Loosen requirements for mixed samples support (Closed)

Created:
5 years, 1 month ago by Chris Dalton
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Loosen requirements for mixed samples support Quits requiring EXT_raster_multisample and NV_sample_mask_override_coverage for mixed samples support. This will allow platforms without those latter extensions (i.e. Chrome) to still use mixed samples for path rendering. Also moves the mixed samples cap out of shader caps, since it no longer denotes shader functionality. BUG=skia: Committed: https://skia.googlesource.com/skia/+/63f6c1fc5b04fb154151f521c97a549060141374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M include/gpu/GrCaps.h View 4 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrCaps.cpp View 4 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +14 lines, -19 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
Chris Dalton
Leaving in the EXT_raster_multisample API, we will add caps for it in the future.
5 years, 1 month ago (2015-11-05 18:50:01 UTC) #2
egdaniel
lgtm
5 years, 1 month ago (2015-11-05 20:50:57 UTC) #3
Chris Dalton
I'll let this sit until tommorrow in case Kimmo has any comments.
5 years, 1 month ago (2015-11-06 02:59:42 UTC) #4
Kimmo Kinnunen
On 2015/11/06 02:59:42, Chris Dalton wrote: > I'll let this sit until tommorrow in case ...
5 years, 1 month ago (2015-11-06 07:38:10 UTC) #5
Kimmo Kinnunen
On 2015/11/06 07:38:10, Kimmo Kinnunen wrote: > On 2015/11/06 02:59:42, Chris Dalton wrote: > > ...
5 years, 1 month ago (2015-11-06 07:41:33 UTC) #6
Chris Dalton
On 2015/11/06 07:41:33, Kimmo Kinnunen wrote: > On 2015/11/06 07:38:10, Kimmo Kinnunen wrote: > > ...
5 years, 1 month ago (2015-11-06 14:47:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410383011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410383011/1
5 years, 1 month ago (2015-11-06 14:47:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3713)
5 years, 1 month ago (2015-11-06 14:48:17 UTC) #11
bsalomon
On 2015/11/06 14:48:17, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-06 15:08:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410383011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410383011/1
5 years, 1 month ago (2015-11-06 15:09:08 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 15:09:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/63f6c1fc5b04fb154151f521c97a549060141374

Powered by Google App Engine
This is Rietveld 408576698