Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1410343012: Revert of Move more declarations from c/b/sb/sb_util.h to components. (Closed)

Created:
5 years, 1 month ago by binjin
Modified:
5 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, droger+watchlist_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, blundell+watchlist_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@01_components
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move more declarations from c/b/sb/sb_util.h to components. (patchset #9 id:160001 of https://codereview.chromium.org/1420123003/ ) Reason for revert: Suspected to break the win compile: FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/safe_browsing_db/util/util.obj.rsp /c ../../components/safe_browsing_db/util.cc /Foobj/components/safe_browsing_db/util/util.obj /Fdobj/components/safe_browsing_db/util_cc.pdb e:\b\build\slave\win_x64_gn__dbg_\build\src\components\safe_browsing_db\util.cc(225) :error C2220: warning treated as error - no 'object' file generated Original issue's description: > 1. Pull all code unrelated to chunking from chrome/browser/safe_browsing/safe_brwsing_util.h into components/safe_browsing_db. > 2. All code that was formerly under the safe_browsing_util namespace is now under safe_browsing. That's the only namespace we plan to use going forward. > 3. Chunking related code will stay in the old location and removed once we switch to PVER4. > > The next CL in this series will move the structures/enums currently under the global namespace in safe_browsing_db_util.h into safe_browsing. I did not do that as part of this CL to keep it smaller and easier to review. > > BUG=543161 > > Committed: https://crrev.com/154455e8186ad19a8b54ca23e344ade0d92c34cf > Cr-Commit-Position: refs/heads/master@{#357763} TBR=mattm@chromium.org,nparker@chromium.org,blundell@chromium.org,thestig@chromium.org,vakh@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543161 Committed: https://crrev.com/f4a26a6f70be96339e0eb683fdc83cb81880171a Cr-Commit-Position: refs/heads/master@{#357804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1089 lines, -1224 lines) Patch
M chrome/browser/extensions/fake_safe_browsing_database_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/database_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.cc View 17 chunks +55 lines, -56 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager_unittest.cc View 6 chunks +22 lines, -25 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 8 chunks +17 lines, -21 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 18 chunks +42 lines, -47 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 60 chunks +103 lines, -114 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 15 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc View 9 chunks +13 lines, -19 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_unittest.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.h View 3 chunks +98 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 2 chunks +355 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/safe_browsing_util_unittest.cc View 1 chunk +323 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
M components/safe_browsing_db/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing_db/prefix_set.h View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/prefix_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/safe_browsing_db/util.h View 1 chunk +0 lines, -167 lines 0 comments Download
D components/safe_browsing_db/util.cc View 1 chunk +0 lines, -371 lines 0 comments Download
D components/safe_browsing_db/util_unittest.cc View 1 chunk +0 lines, -339 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
binjin
Created Revert of Move more declarations from c/b/sb/sb_util.h to components.
5 years, 1 month ago (2015-11-04 12:13:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343012/1
5 years, 1 month ago (2015-11-04 12:14:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 12:15:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f4a26a6f70be96339e0eb683fdc83cb81880171a Cr-Commit-Position: refs/heads/master@{#357804}
5 years, 1 month ago (2015-11-04 12:16:08 UTC) #4
blundell
Please in general add a link to the failing bot run in the CL description ...
5 years, 1 month ago (2015-11-04 12:43:37 UTC) #5
binjin
On 2015/11/04 12:43:37, blundell wrote: > Please in general add a link to the failing ...
5 years, 1 month ago (2015-11-04 12:46:12 UTC) #6
blundell
5 years, 1 month ago (2015-11-04 12:56:22 UTC) #7
Message was sent while issue was closed.
On 2015/11/04 12:46:12, binjin wrote:
> On 2015/11/04 12:43:37, blundell wrote:
> > Please in general add a link to the failing bot run in the CL description
> > for
> > the revert. Can you provide that link here?
> 
>
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/...

Thanks! Including a snippet as you did is also a really good idea, to be clear
-- it's nice to have both.

Powered by Google App Engine
This is Rietveld 408576698