Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc

Issue 1410343012: Revert of Move more declarations from c/b/sb/sb_util.h to components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_components
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
index 91e6fb3e92d8ecad562d3f834375b4602dc6ca32..768b90b41b171e17bd51426dbdd6899594a3c3c7 100644
--- a/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
@@ -13,7 +13,6 @@
#include "base/test/test_simple_task_runner.h"
#include "chrome/common/chrome_paths.h"
#include "components/safe_browsing_db/prefix_set.h"
-#include "components/safe_browsing_db/util.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
@@ -27,12 +26,12 @@
const int kSubChunk1 = 2;
const int kSubChunk2 = 4;
-const SBFullHash kHash1 = safe_browsing::SBFullHashForString("one");
-const SBFullHash kHash2 = safe_browsing::SBFullHashForString("two");
-const SBFullHash kHash3 = safe_browsing::SBFullHashForString("three");
-const SBFullHash kHash4 = safe_browsing::SBFullHashForString("four");
-const SBFullHash kHash5 = safe_browsing::SBFullHashForString("five");
-const SBFullHash kHash6 = safe_browsing::SBFullHashForString("six");
+const SBFullHash kHash1 = SBFullHashForString("one");
+const SBFullHash kHash2 = SBFullHashForString("two");
+const SBFullHash kHash3 = SBFullHashForString("three");
+const SBFullHash kHash4 = SBFullHashForString("four");
+const SBFullHash kHash5 = SBFullHashForString("five");
+const SBFullHash kHash6 = SBFullHashForString("six");
const SBPrefix kMinSBPrefix = 0u;
const SBPrefix kMaxSBPrefix = ~kMinSBPrefix;
@@ -195,8 +194,7 @@
ASSERT_EQ(1U, add_full_hashes_result.size());
EXPECT_EQ(kAddChunk2, add_full_hashes_result[0].chunk_id);
- EXPECT_TRUE(safe_browsing::SBFullHashEqual(
- kHash4, add_full_hashes_result[0].full_hash));
+ EXPECT_TRUE(SBFullHashEqual(kHash4, add_full_hashes_result[0].full_hash));
}
}
@@ -281,8 +279,7 @@
ASSERT_EQ(1U, add_full_hashes_result.size());
EXPECT_EQ(kAddChunk2, add_full_hashes_result[0].chunk_id);
- EXPECT_TRUE(safe_browsing::SBFullHashEqual(
- kHash4, add_full_hashes_result[0].full_hash));
+ EXPECT_TRUE(SBFullHashEqual(kHash4, add_full_hashes_result[0].full_hash));
}
ASSERT_TRUE(store_->BeginUpdate());
@@ -305,8 +302,7 @@
ASSERT_EQ(1U, add_full_hashes_result.size());
EXPECT_EQ(kAddChunk2, add_full_hashes_result[0].chunk_id);
- EXPECT_TRUE(safe_browsing::SBFullHashEqual(
- kHash4, add_full_hashes_result[0].full_hash));
+ EXPECT_TRUE(SBFullHashEqual(kHash4, add_full_hashes_result[0].full_hash));
}
ASSERT_TRUE(store_->BeginUpdate());
@@ -330,8 +326,7 @@
ASSERT_EQ(1U, add_full_hashes_result.size());
EXPECT_EQ(kAddChunk2, add_full_hashes_result[0].chunk_id);
- EXPECT_TRUE(safe_browsing::SBFullHashEqual(
- kHash4, add_full_hashes_result[0].full_hash));
+ EXPECT_TRUE(SBFullHashEqual(kHash4, add_full_hashes_result[0].full_hash));
}
}
@@ -397,8 +392,7 @@
ASSERT_EQ(1U, add_full_hashes_result.size());
EXPECT_EQ(kAddChunk3, add_full_hashes_result[0].chunk_id);
- EXPECT_TRUE(safe_browsing::SBFullHashEqual(
- kHash6, add_full_hashes_result[0].full_hash));
+ EXPECT_TRUE(SBFullHashEqual(kHash6, add_full_hashes_result[0].full_hash));
}
// Expected chunks are there in another update.
@@ -671,7 +665,7 @@
EXPECT_TRUE(store_->GetAddFullHashes(&add_hashes));
ASSERT_EQ(1U, add_hashes.size());
EXPECT_EQ(kAddChunk2, add_hashes[0].chunk_id);
- EXPECT_TRUE(safe_browsing::SBFullHashEqual(kHash4, add_hashes[0].full_hash));
+ EXPECT_TRUE(SBFullHashEqual(kHash4, add_hashes[0].full_hash));
}
// Test that the database handles resharding correctly, both when growing and
@@ -813,7 +807,7 @@
EXPECT_TRUE(store_->GetAddFullHashes(&add_hashes));
ASSERT_EQ(1U, add_hashes.size());
EXPECT_EQ(kAddChunk1, add_hashes[0].chunk_id);
- EXPECT_TRUE(safe_browsing::SBFullHashEqual(kHash2, add_hashes[0].full_hash));
+ EXPECT_TRUE(SBFullHashEqual(kHash2, add_hashes[0].full_hash));
// Attempt an update to make sure things work end-to-end.
EXPECT_TRUE(store_->BeginUpdate());

Powered by Google App Engine
This is Rietveld 408576698