Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1409923003: Revert of Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what… (Closed)

Created:
5 years, 2 months ago by egdaniel
Modified:
5 years, 2 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@move
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what… (patchset #4 id:60001 of https://codereview.chromium.org/1409163002/ ) Reason for revert: breaking nanobench Original issue's description: > Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what copying needs to be done. > > Committed: https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79 TBR=reed@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/91957941ce2fe9457babe7f83514e4599089d411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+541 lines, -515 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrResourceKey.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/core/SkImageCacherator.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 4 chunks +47 lines, -44 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
A src/gpu/GrTextureMaker.h View 1 chunk +76 lines, -0 lines 0 comments Download
D src/gpu/GrTextureParamsAdjuster.h View 1 chunk +0 lines, -107 lines 0 comments Download
D src/gpu/GrTextureParamsAdjuster.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
M src/gpu/SkGr.cpp View 11 chunks +338 lines, -118 lines 0 comments Download
M src/gpu/SkGrPriv.h View 2 chunks +28 lines, -15 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 2 chunks +31 lines, -26 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
egdaniel
5 years, 2 months ago (2015-10-16 20:58:56 UTC) #1
Created Revert of Rewrite GrTextureMaker to disentangle bitmap case from base
class and give GPU object a say in what…

Powered by Google App Engine
This is Rietveld 408576698