Issue 140933005: Remove GR_GL_IGNORE_ES3_MSAA.s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140933005: Remove GR_GL_IGNORE_ES3_MSAA.s (Closed)

Created:
6 years, 11 months ago by bsalomon

Modified:
6 years, 11 months ago

Reviewers:
jvanverth1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove GR_GL_IGNORE_ES3_MSAA.s Committed: http://code.google.com/p/skia/source/detail?r=13115

Patch Set 2 : fix whitespace #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -75 lines)			Patch
M	include/gpu/gl/GrGLConfig.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	include/gpu/gl/GrGLInterface.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLInterface.cpp	View		2 chunks	+0 lines, -20 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp	View	1	1 chunk	+14 lines, -35 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

https://codereview.chromium.org/140933005/diff/30001/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp File src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp (right): https://codereview.chromium.org/140933005/diff/30001/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp#newcode151 src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp:151: if (version >= GR_GL_VER(3,0)) { The change here was ...

6 years, 11 months ago (2014-01-16 19:49:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/140933005/30001

6 years, 11 months ago (2014-01-16 20:36:40 UTC) #3

Message was sent while issue was closed.

Change committed as 13115

Expand Messages | Collapse Messages

Issue 140933005: Remove GR_GL_IGNORE_ES3_MSAA.s (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix whitespace #

Messages