Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what…

Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what copying needs to be done.

Committed: https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79

Committed: https://skia.googlesource.com/skia/+/1a197ea31e0aac7ea312e9a6c0d9f5df626b0350

Committed: https://skia.googlesource.com/skia/+/045802dbb7202b52f5fd2758d725f39c156a6165

[bsalomon, 2015-10-16 18:54:30]

bsalomon@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-10-16 19:23:42]

SkGr.cpp got 200 lines shorter, so it must be a good CL.

lgtm

https://codereview.chromium.org/1409163002/diff/20001/include/gpu/SkGr.h
File include/gpu/SkGr.h (right):

https://codereview.chromium.org/1409163002/diff/20001/include/gpu/SkGr.h#newc...
include/gpu/SkGr.h:68: /** Returns a texture representing the bitmap that is
compatible with the GrTextureParams */
I presume the texture has already been "cached", as the name implies?

[bsalomon, 2015-10-16 20:09:45]

https://codereview.chromium.org/1409163002/diff/20001/include/gpu/SkGr.h
File include/gpu/SkGr.h (right):

https://codereview.chromium.org/1409163002/diff/20001/include/gpu/SkGr.h#newc...
include/gpu/SkGr.h:68: /** Returns a texture representing the bitmap that is
compatible with the GrTextureParams */
On 2015/10/16 19:23:42, reed1 wrote:
> I presume the texture has already been "cached", as the name implies?

Yup, will update the comment.

[bsalomon, 2015-10-16 20:20:29]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-16 20:20:30]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1409163002/#ps40001
(title: "update comment")

[commit-bot: I haz the power, 2015-10-16 20:20:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409163002/40001

[commit-bot: I haz the power, 2015-10-16 20:21:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 20:21:38]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2015-10-16 20:25:44]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-16 20:25:44]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1409163002/#ps60001
(title: "fix extra qualifier, missed cleanup of extra key gen")

[commit-bot: I haz the power, 2015-10-16 20:25:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409163002/60001

[commit-bot: I haz the power, 2015-10-16 20:35:13]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79

[egdaniel, 2015-10-16 20:58:55]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1409923003/ by egdaniel@google.com.

The reason for reverting is: breaking nanobench.

[bsalomon, 2015-10-19 15:14:49]

Description was changed from

==========
Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU
object a say in what copying needs to be done.

Committed:
https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79
==========

to

==========
Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU
object a say in what copying needs to be done.

Committed:
https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79
==========

[bsalomon, 2015-10-19 15:14:52]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-19 15:14:52]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1409163002/#ps80001
(title: "Don't try to set invalid key")

[commit-bot: I haz the power, 2015-10-19 15:15:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409163002/80001

[commit-bot: I haz the power, 2015-10-19 15:24:13]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/1a197ea31e0aac7ea312e9a6c0d9f5df626b0350

[bsalomon, 2015-10-20 14:47:41]

Description was changed from

==========
Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU
object a say in what copying needs to be done.

Committed:
https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79

Committed:
https://skia.googlesource.com/skia/+/1a197ea31e0aac7ea312e9a6c0d9f5df626b0350
==========

to

==========
Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU
object a say in what copying needs to be done.

Committed:
https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79

Committed:
https://skia.googlesource.com/skia/+/1a197ea31e0aac7ea312e9a6c0d9f5df626b0350
==========

[bsalomon, 2015-10-20 14:47:46]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-20 14:47:46]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1409163002/#ps120001
(title: "tidy")

[commit-bot: I haz the power, 2015-10-20 14:47:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409163002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409163002/120001

[commit-bot: I haz the power, 2015-10-20 14:58:04]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/045802dbb7202b52f5fd2758d725f39c156a6165