Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1407133019: Revert of Make SkBlurImageFilter capable of cropping during blur (GPU path). (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org
Base URL:
senorblanco-linux.mon:src/skia@blur-applyCropRect4-separate-loops
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make SkBlurImageFilter capable of cropping during blur (GPU path). (patchset #15 id:260001 of https://codereview.chromium.org/1431593002/ ) Reason for revert: Causing valgrind error. Looks like the issue is in conolve_gaussiand_2d where bounds is not getting set if there is no srcBounds, but later on that bounds is being read in the creation of a TextureDomain. Original issue's description: > Make SkBlurImageFilter capable of cropping during blur (GPU path). > > This is the GPU equivalent of https://codereview.chromium.org/1415653003/. > > It requires passing down the bounds of the crop rect (srcBounds), and > turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch: > clear above and below srcBounds, blur with bounds checks inside left and > right rects, blur without bounds checks in middle rect. > > Note: this change causes minor pixels diffs in the > imagefilterscropexpand GM: for odd crop positions relative to the > dstBounds, we are now correctly resampling at an even pixel boundary. > > BUG=skia:4502, skia:4526 > > Committed: https://skia.googlesource.com/skia/+/c57e0ded7d535523cfc6bf07c78e5f3479bb8c42 TBR=bsalomon@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4502, skia:4526 Committed: https://skia.googlesource.com/skia/+/edce2a8576c4f701674d925731e10e569e9dc9b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -101 lines) Patch
M src/effects/SkBlurImageFilter.cpp View 1 chunk +8 lines, -10 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 13 chunks +49 lines, -85 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
egdaniel
Created Revert of Make SkBlurImageFilter capable of cropping during blur (GPU path).
5 years, 1 month ago (2015-11-09 18:04:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407133019/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407133019/1
5 years, 1 month ago (2015-11-09 18:04:12 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 18:04:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/edce2a8576c4f701674d925731e10e569e9dc9b0

Powered by Google App Engine
This is Rietveld 408576698