Do not allow large object allocation from optimized code.

Do not allow large object allocation from optimized code.

BUG=

Committed: https://crrev.com/c1a81536eddb85583692eb7b73f5bb18815d1b4c
Cr-Commit-Position: refs/heads/master@{#31244}

[Hannes Payer (out of office), 2015-10-13 18:25:57]

hpayer@chromium.org changed reviewers:
+ mstarzinger@chromium.org, mvstanton@chromium.org

[Michael Starzinger, 2015-10-13 18:30:28]

LGTM. Many good, much wow, such invariant, so not LO-space.

https://codereview.chromium.org/1406593002/diff/1/src/ia32/lithium-codegen-ia...
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/1406593002/diff/1/src/ia32/lithium-codegen-ia...
src/ia32/lithium-codegen-ia32.cc:5184:
CHECK(!instr->hydrogen()->IsNewSpaceAllocation());
Is this on purpose? Or did it slip in? Maybe TODO to make it a DCHECK again?

[mvstanton, 2015-10-13 18:47:24]

It looks okay to me too (LGTM), but why is this being done right now, is it a
bug or something?

[Hannes Payer (out of office), 2015-10-13 18:58:14]

You will not get write barriers on a NEW_SPACE large object allocation. So yes,
it is a bug which was flushed out with another CL.

https://codereview.chromium.org/1406593002/diff/1/src/ia32/lithium-codegen-ia...
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/1406593002/diff/1/src/ia32/lithium-codegen-ia...
src/ia32/lithium-codegen-ia32.cc:5184:
CHECK(!instr->hydrogen()->IsNewSpaceAllocation());
On 2015/10/13 18:30:28, Michael Starzinger wrote:
> Is this on purpose? Or did it slip in? Maybe TODO to make it a DCHECK again?

Done.

[Hannes Payer (out of office), 2015-10-13 18:59:25]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-10-13 18:59:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1406593002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-10-13 18:59:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406593002/20001

[commit-bot: I haz the power, 2015-10-13 19:20:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-13 19:20:33]

Patchset 2 (id:??) landed as
https://crrev.com/c1a81536eddb85583692eb7b73f5bb18815d1b4c
Cr-Commit-Position: refs/heads/master@{#31244}