Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x87/lithium-codegen-x87.cc

Issue 1406593002: Do not allow large object allocation from optimized code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 5781 matching lines...) Expand 10 before | Expand all | Expand 10 after
5792 if (instr->hydrogen()->MustAllocateDoubleAligned()) { 5792 if (instr->hydrogen()->MustAllocateDoubleAligned()) {
5793 flags = static_cast<AllocationFlags>(flags | DOUBLE_ALIGNMENT); 5793 flags = static_cast<AllocationFlags>(flags | DOUBLE_ALIGNMENT);
5794 } 5794 }
5795 if (instr->hydrogen()->IsOldSpaceAllocation()) { 5795 if (instr->hydrogen()->IsOldSpaceAllocation()) {
5796 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 5796 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
5797 flags = static_cast<AllocationFlags>(flags | PRETENURE); 5797 flags = static_cast<AllocationFlags>(flags | PRETENURE);
5798 } 5798 }
5799 5799
5800 if (instr->size()->IsConstantOperand()) { 5800 if (instr->size()->IsConstantOperand()) {
5801 int32_t size = ToInteger32(LConstantOperand::cast(instr->size())); 5801 int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));
5802 if (size <= Page::kMaxRegularHeapObjectSize) { 5802 CHECK(size <= Page::kMaxRegularHeapObjectSize);
5803 __ Allocate(size, result, temp, no_reg, deferred->entry(), flags); 5803 __ Allocate(size, result, temp, no_reg, deferred->entry(), flags);
5804 } else {
5805 __ jmp(deferred->entry());
5806 }
5807 } else { 5804 } else {
5808 Register size = ToRegister(instr->size()); 5805 Register size = ToRegister(instr->size());
5809 __ Allocate(size, result, temp, no_reg, deferred->entry(), flags); 5806 __ Allocate(size, result, temp, no_reg, deferred->entry(), flags);
5810 } 5807 }
5811 5808
5812 __ bind(deferred->exit()); 5809 __ bind(deferred->exit());
5813 5810
5814 if (instr->hydrogen()->MustPrefillWithFiller()) { 5811 if (instr->hydrogen()->MustPrefillWithFiller()) {
5815 if (instr->size()->IsConstantOperand()) { 5812 if (instr->size()->IsConstantOperand()) {
5816 int32_t size = ToInteger32(LConstantOperand::cast(instr->size())); 5813 int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
6332 RecordSafepoint(Safepoint::kNoLazyDeopt); 6329 RecordSafepoint(Safepoint::kNoLazyDeopt);
6333 } 6330 }
6334 6331
6335 6332
6336 #undef __ 6333 #undef __
6337 6334
6338 } // namespace internal 6335 } // namespace internal
6339 } // namespace v8 6336 } // namespace v8
6340 6337
6341 #endif // V8_TARGET_ARCH_X87 6338 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698