Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/mips64/lithium-codegen-mips64.cc

Issue 1406593002: Do not allow large object allocation from optimized code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/ppc/lithium-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/code-stubs.h" 6 #include "src/code-stubs.h"
7 #include "src/hydrogen-osr.h" 7 #include "src/hydrogen-osr.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/mips64/lithium-codegen-mips64.h" 10 #include "src/mips64/lithium-codegen-mips64.h"
(...skipping 5483 matching lines...) Expand 10 before | Expand all | Expand 10 after
5494 AllocationFlags flags = TAG_OBJECT; 5494 AllocationFlags flags = TAG_OBJECT;
5495 if (instr->hydrogen()->MustAllocateDoubleAligned()) { 5495 if (instr->hydrogen()->MustAllocateDoubleAligned()) {
5496 flags = static_cast<AllocationFlags>(flags | DOUBLE_ALIGNMENT); 5496 flags = static_cast<AllocationFlags>(flags | DOUBLE_ALIGNMENT);
5497 } 5497 }
5498 if (instr->hydrogen()->IsOldSpaceAllocation()) { 5498 if (instr->hydrogen()->IsOldSpaceAllocation()) {
5499 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 5499 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
5500 flags = static_cast<AllocationFlags>(flags | PRETENURE); 5500 flags = static_cast<AllocationFlags>(flags | PRETENURE);
5501 } 5501 }
5502 if (instr->size()->IsConstantOperand()) { 5502 if (instr->size()->IsConstantOperand()) {
5503 int32_t size = ToInteger32(LConstantOperand::cast(instr->size())); 5503 int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));
5504 if (size <= Page::kMaxRegularHeapObjectSize) { 5504 CHECK(size <= Page::kMaxRegularHeapObjectSize);
5505 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags); 5505 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags);
5506 } else {
5507 __ jmp(deferred->entry());
5508 }
5509 } else { 5506 } else {
5510 Register size = ToRegister(instr->size()); 5507 Register size = ToRegister(instr->size());
5511 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags); 5508 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags);
5512 } 5509 }
5513 5510
5514 __ bind(deferred->exit()); 5511 __ bind(deferred->exit());
5515 5512
5516 if (instr->hydrogen()->MustPrefillWithFiller()) { 5513 if (instr->hydrogen()->MustPrefillWithFiller()) {
5517 STATIC_ASSERT(kHeapObjectTag == 1); 5514 STATIC_ASSERT(kHeapObjectTag == 1);
5518 if (instr->size()->IsConstantOperand()) { 5515 if (instr->size()->IsConstantOperand()) {
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
6078 __ Push(at, ToRegister(instr->function())); 6075 __ Push(at, ToRegister(instr->function()));
6079 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6076 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6080 RecordSafepoint(Safepoint::kNoLazyDeopt); 6077 RecordSafepoint(Safepoint::kNoLazyDeopt);
6081 } 6078 }
6082 6079
6083 6080
6084 #undef __ 6081 #undef __
6085 6082
6086 } // namespace internal 6083 } // namespace internal
6087 } // namespace v8 6084 } // namespace v8
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/ppc/lithium-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698