Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 1406593002: Do not allow large object allocation from optimized code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/arm/lithium-codegen-arm.h" 5 #include "src/arm/lithium-codegen-arm.h"
6 #include "src/arm/lithium-gap-resolver-arm.h" 6 #include "src/arm/lithium-gap-resolver-arm.h"
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/hydrogen-osr.h" 10 #include "src/hydrogen-osr.h"
(...skipping 5287 matching lines...) Expand 10 before | Expand all | Expand 10 after
5298 if (instr->hydrogen()->MustAllocateDoubleAligned()) { 5298 if (instr->hydrogen()->MustAllocateDoubleAligned()) {
5299 flags = static_cast<AllocationFlags>(flags | DOUBLE_ALIGNMENT); 5299 flags = static_cast<AllocationFlags>(flags | DOUBLE_ALIGNMENT);
5300 } 5300 }
5301 if (instr->hydrogen()->IsOldSpaceAllocation()) { 5301 if (instr->hydrogen()->IsOldSpaceAllocation()) {
5302 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 5302 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
5303 flags = static_cast<AllocationFlags>(flags | PRETENURE); 5303 flags = static_cast<AllocationFlags>(flags | PRETENURE);
5304 } 5304 }
5305 5305
5306 if (instr->size()->IsConstantOperand()) { 5306 if (instr->size()->IsConstantOperand()) {
5307 int32_t size = ToInteger32(LConstantOperand::cast(instr->size())); 5307 int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));
5308 if (size <= Page::kMaxRegularHeapObjectSize) { 5308 CHECK(size <= Page::kMaxRegularHeapObjectSize);
5309 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags); 5309 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags);
5310 } else {
5311 __ jmp(deferred->entry());
5312 }
5313 } else { 5310 } else {
5314 Register size = ToRegister(instr->size()); 5311 Register size = ToRegister(instr->size());
5315 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags); 5312 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags);
5316 } 5313 }
5317 5314
5318 __ bind(deferred->exit()); 5315 __ bind(deferred->exit());
5319 5316
5320 if (instr->hydrogen()->MustPrefillWithFiller()) { 5317 if (instr->hydrogen()->MustPrefillWithFiller()) {
5321 STATIC_ASSERT(kHeapObjectTag == 1); 5318 STATIC_ASSERT(kHeapObjectTag == 1);
5322 if (instr->size()->IsConstantOperand()) { 5319 if (instr->size()->IsConstantOperand()) {
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
5836 __ push(ToRegister(instr->function())); 5833 __ push(ToRegister(instr->function()));
5837 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5834 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5838 RecordSafepoint(Safepoint::kNoLazyDeopt); 5835 RecordSafepoint(Safepoint::kNoLazyDeopt);
5839 } 5836 }
5840 5837
5841 5838
5842 #undef __ 5839 #undef __
5843 5840
5844 } // namespace internal 5841 } // namespace internal
5845 } // namespace v8 5842 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698