Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1406033007: Delete dead BitmapRegionDecoder code in tools (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@delete-dm
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete dead BitmapRegionDecoder code in tools This approach to subset decoding is no longer supported. We have replaced it with an implementation that does not depend on forked libraries. https://codereview.chromium.org/1406153015/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/5c9e34a350cd641910c86151aa39f863cdf25cc3

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -112 lines) Patch
M dm/DM.cpp View 1 chunk +0 lines, -17 lines 1 comment Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/SkBitmapRegionDecoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/SkBitmapRegionDecoder.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
D tools/SkBitmapRegionSampler.h View 1 chunk +0 lines, -45 lines 0 comments Download
D tools/SkBitmapRegionSampler.cpp View 1 chunk +0 lines, -33 lines 0 comments Download

Depends on Patchset:

Issue 1416673010 Patch 20001

Dependent Patchsets:

Issue 1426943009 Patch 1

Messages

Total messages: 7 (3 generated)
msarett
https://codereview.chromium.org/1406033007/diff/20001/dm/DM.cpp File dm/DM.cpp (left): https://codereview.chromium.org/1406033007/diff/20001/dm/DM.cpp#oldcode479 dm/DM.cpp:479: Missed this in DM CL.
5 years, 1 month ago (2015-11-10 16:39:09 UTC) #3
scroggo
lgtm
5 years, 1 month ago (2015-11-10 18:53:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406033007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406033007/20001
5 years, 1 month ago (2015-11-10 23:10:57 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 23:24:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/5c9e34a350cd641910c86151aa39f863cdf25cc3

Powered by Google App Engine
This is Rietveld 408576698