Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: dm/DM.cpp

Issue 1406033007: Delete dead BitmapRegionDecoder code in tools (Closed) Base URL: https://skia.googlesource.com/skia.git@delete-dm
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/tools.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 444584d89639644567cf158a8ef813422552af19..9bedd4f5232d793094fcde36fc62a827b521b974 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -476,24 +476,7 @@ static void push_brd_srcs(Path path) {
};
for (SkBitmapRegionDecoder::Strategy strategy : strategies) {
-
msarett 2015/11/10 16:39:09 Missed this in DM CL.
- // We disable png testing for kOriginal_Strategy because the implementation leaks
- // memory in our forked libpng.
- // TODO (msarett): Decide if we want to test pngs in this mode and how we might do this.
- if (SkBitmapRegionDecoder::kOriginal_Strategy == strategy &&
- (path.endsWith(".png") || path.endsWith(".PNG"))) {
- continue;
- }
for (uint32_t sampleSize : sampleSizes) {
-
- // kOriginal_Strategy does not work for jpegs that are scaled to non-powers of two.
- // We don't need to test this. We know it doesn't work, and it causes images with
- // uninitialized memory to show up on Gold.
- if (SkBitmapRegionDecoder::kOriginal_Strategy == strategy &&
- (path.endsWith(".jpg") || path.endsWith(".JPG") ||
- path.endsWith(".jpeg") || path.endsWith(".JPEG")) && !SkIsPow2(sampleSize)) {
- continue;
- }
for (CodecSrc::DstColorType dstColorType : dstColorTypes) {
if (brd_color_type_supported(strategy, dstColorType)) {
for (BRDSrc::Mode mode : modes) {
« no previous file with comments | « no previous file | gyp/tools.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698