Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1416673010: Delete dead subset test code from dm (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@delete
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete dead subset test code from dm This approach to subset decoding is no longer supported. We have replaced it with an implementation that does not depend on forked libraries. https://codereview.chromium.org/1406153015/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/164d302ebf182a2db0044ba46126f9ed1e6cf138

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -71 lines) Patch
M dm/DM.cpp View 1 5 chunks +0 lines, -15 lines 0 comments Download
M dm/DMSrcSink.h View 2 chunks +1 line, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +11 lines, -52 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
msarett
5 years, 1 month ago (2015-11-10 16:31:15 UTC) #2
scroggo
lgtm
5 years, 1 month ago (2015-11-10 18:54:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416673010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416673010/20001
5 years, 1 month ago (2015-11-10 22:57:56 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 23:09:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/164d302ebf182a2db0044ba46126f9ed1e6cf138

Powered by Google App Engine
This is Rietveld 408576698