Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1426943009: Delete dead SkImageDecoder::buildTileIndex and decodeSubset code (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@delete-tools
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete dead SkImageDecoder::buildTileIndex and decodeSubset code This approach to subset decoding is no longer supported. We have replaced it with an implementation that does not depend on forked libraries. https://codereview.chromium.org/1406153015/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/5c351f38fa365b03326454ad3e2ecc5dfb8184fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -925 lines) Patch
M include/core/SkImageDecoder.h View 3 chunks +0 lines, -49 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 4 chunks +0 lines, -390 lines 0 comments Download
M src/images/SkImageDecoder_libpng.cpp View 4 chunks +0 lines, -278 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 4 chunks +0 lines, -118 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 2 chunks +0 lines, -20 lines 0 comments Download

Depends on Patchset:

Issue 1406033007 Patch 20001

Dependent Patchsets:

Issue 1417393004 Patch 1
Issue 1417393004 Patch 20001
Issue 1417393004 Patch 40001

Messages

Total messages: 7 (2 generated)
msarett
5 years, 1 month ago (2015-11-10 16:54:02 UTC) #2
reed1
api lgtm
5 years, 1 month ago (2015-11-10 18:02:59 UTC) #3
scroggo
On 2015/11/10 18:02:59, reed1 wrote: > api lgtm Yay! lgtm
5 years, 1 month ago (2015-11-10 18:47:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426943009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426943009/1
5 years, 1 month ago (2015-11-10 23:25:56 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 23:38:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5c351f38fa365b03326454ad3e2ecc5dfb8184fc

Powered by Google App Engine
This is Rietveld 408576698