Fixes shutdown crashes.

Fixes shutdown crashes.

- Restores fix to debug message queue.
- Fixes for precompilation.

BUG=
R=johnmccutchan@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/1fb050baa0fbff42ffc9f4d12ebbe92402880643

[zra, 2015-10-26 20:51:09]

zra@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com

[zra, 2015-10-26 20:51:10]

https://codereview.chromium.org/1406013004/diff/1/runtime/bin/dbg_message.cc
File runtime/bin/dbg_message.cc (right):

https://codereview.chromium.org/1406013004/diff/1/runtime/bin/dbg_message.cc#...
runtime/bin/dbg_message.cc:1415: if (msg_queue != NULL) {
The vm isolate does not have a debug message queue.

[rmacnak, 2015-10-26 21:38:15]

precompilation lgtm w/ suggested rename

https://codereview.chromium.org/1406013004/diff/20001/runtime/vm/virtual_memo...
File runtime/vm/virtual_memory.cc (right):

https://codereview.chromium.org/1406013004/diff/20001/runtime/vm/virtual_memo...
runtime/vm/virtual_memory.cc:37: memory->dummy_ = true;
How about embedder_allocated_ ?

[Cutch, 2015-10-26 21:39:44]

https://codereview.chromium.org/1406013004/diff/20001/runtime/bin/dbg_message.cc
File runtime/bin/dbg_message.cc (right):

https://codereview.chromium.org/1406013004/diff/20001/runtime/bin/dbg_message...
runtime/bin/dbg_message.cc:1415: if (msg_queue != NULL) {
As discussed offline- this should remain an ASSERT because we shouldn't be
notifying the embedder that an isolate was shutdown when we never notified it
that it was created in the first place. We also don't want to leak information
about the vm-isolate to the embedder here.

https://codereview.chromium.org/1406013004/diff/20001/runtime/vm/service_isol...
File runtime/vm/service_isolate.cc (right):

https://codereview.chromium.org/1406013004/diff/20001/runtime/vm/service_isol...
runtime/vm/service_isolate.cc:304: ServiceIsolate::SetServiceIsolate(NULL);
This isn't needed. The default value of the service isolate is NULL.

[zra, 2015-10-26 21:49:58]

https://codereview.chromium.org/1406013004/diff/20001/runtime/bin/dbg_message.cc
File runtime/bin/dbg_message.cc (right):

https://codereview.chromium.org/1406013004/diff/20001/runtime/bin/dbg_message...
runtime/bin/dbg_message.cc:1415: if (msg_queue != NULL) {
On 2015/10/26 21:39:44, Cutch wrote:
> As discussed offline- this should remain an ASSERT because we shouldn't be
> notifying the embedder that an isolate was shutdown when we never notified it
> that it was created in the first place. We also don't want to leak information
> about the vm-isolate to the embedder here.

Done.

https://codereview.chromium.org/1406013004/diff/20001/runtime/vm/service_isol...
File runtime/vm/service_isolate.cc (right):

https://codereview.chromium.org/1406013004/diff/20001/runtime/vm/service_isol...
runtime/vm/service_isolate.cc:304: ServiceIsolate::SetServiceIsolate(NULL);
On 2015/10/26 21:39:44, Cutch wrote:
> This isn't needed. The default value of the service isolate is NULL.

Done.

https://codereview.chromium.org/1406013004/diff/20001/runtime/vm/virtual_memo...
File runtime/vm/virtual_memory.cc (right):

https://codereview.chromium.org/1406013004/diff/20001/runtime/vm/virtual_memo...
runtime/vm/virtual_memory.cc:37: memory->dummy_ = true;
On 2015/10/26 21:38:15, rmacnak wrote:
> How about embedder_allocated_ ?

Done.

[Cutch, 2015-10-26 22:20:58]

lgtm

[zra, 2015-10-26 22:43:30]

Committed patchset #3 (id:40001) manually as
1fb050baa0fbff42ffc9f4d12ebbe92402880643 (presubmit successful).