runtime/vm/virtual_memory.cc - Issue 1406013004: Fixes shutdown crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory.cc

Issue 1406013004: Fixes shutdown crashes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/virtual_memory.cc

diff --git a/runtime/vm/virtual_memory.cc b/runtime/vm/virtual_memory.cc

index 2f2c1bc855681688a6e8a8e7d3d6af33af7b7c64..1ad6c06df3fb2323c3a647f7ae7c1c377611a5f5 100644

--- a/runtime/vm/virtual_memory.cc

+++ b/runtime/vm/virtual_memory.cc

@@ -33,7 +33,9 @@ VirtualMemory* VirtualMemory::ForInstructionsSnapshot(void* pointer,

// Memory for precompilated instructions was allocated by the embedder, so

// create a VirtualMemory without allocating.

MemoryRegion region(pointer, size);

- return new VirtualMemory(region);

+ VirtualMemory* memory = new VirtualMemory(region);

+ memory->embedder_allocated_ = true;

+ return memory;

}

} // namespace dart

« no previous file with comments | « runtime/vm/virtual_memory.h ('k') | runtime/vm/virtual_memory_android.cc » ('j') | no next file with comments »