runtime/vm/virtual_memory_win.cc - Issue 1406013004: Fixes shutdown crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory_win.cc

Issue 1406013004: Fixes shutdown crashes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/virtual_memory_win.cc

diff --git a/runtime/vm/virtual_memory_win.cc b/runtime/vm/virtual_memory_win.cc

index 100041766bcf5753e33407475c70592e63312f4a..dd154ac1c0fbdcaa0982ac82d5e4248f31a4ac21 100644

--- a/runtime/vm/virtual_memory_win.cc

+++ b/runtime/vm/virtual_memory_win.cc

@@ -33,7 +33,7 @@ VirtualMemory* VirtualMemory::ReserveInternal(intptr_t size) {

VirtualMemory::~VirtualMemory() {

- if (reserved_size_ == 0) {

+ if (embedder_allocated() || (reserved_size_ == 0)) {

return;

}

if (VirtualFree(address(), 0, MEM_RELEASE) == 0) {

« no previous file with comments | « runtime/vm/virtual_memory_macos.cc ('k') | no next file » | no next file with comments »