runtime/vm/service_isolate.cc - Issue 1406013004: Fixes shutdown crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service_isolate.cc

Issue 1406013004: Fixes shutdown crashes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service_isolate.cc

diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc

index bd73eb83ddb3e360514f00c6745f101245c35dbf..98cbeb957f7b42abdc8278494681b91bb35100f9 100644

--- a/runtime/vm/service_isolate.cc

+++ b/runtime/vm/service_isolate.cc

@@ -319,6 +319,7 @@ class RunServiceTask : public ThreadPool::Task {

&error));

if (isolate == NULL) {

OS::PrintErr("vm-service: Isolate creation error: %s\n", error);

+ ServiceIsolate::SetServiceIsolate(NULL);

ServiceIsolate::FinishedInitializing();

return;

}

« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/virtual_memory.h » ('j') | no next file with comments »