Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404823005: GrDrawContext now holds GrRenderTarget pointer (Closed)

Created:
5 years, 2 months ago by robertphillips
Modified:
5 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GrDrawContext now holds GrRenderTarget pointer Committed: https://skia.googlesource.com/skia/+/2e1e51f04985f7c258b96f0decc190456f5dd74d

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 4

Patch Set 3 : fix overlength line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -302 lines) Patch
M gm/texdata.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M include/core/SkMaskFilter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 2 chunks +4 lines, -3 lines 0 comments Download
M include/gpu/GrDrawContext.h View 13 chunks +20 lines, -31 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 7 chunks +4 lines, -9 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 13 chunks +28 lines, -28 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 4 chunks +11 lines, -15 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 7 chunks +11 lines, -14 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 8 chunks +7 lines, -11 lines 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 22 chunks +88 lines, -112 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrYUVProvider.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 21 chunks +22 lines, -29 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +6 lines, -9 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
robertphillips
5 years, 2 months ago (2015-10-15 14:21:39 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1404823005/diff/20001/src/effects/SkAlphaThresholdFilter.cpp File src/effects/SkAlphaThresholdFilter.cpp (right): https://codereview.chromium.org/1404823005/diff/20001/src/effects/SkAlphaThresholdFilter.cpp#newcode275 src/effects/SkAlphaThresholdFilter.cpp:275: SkAutoTUnref<GrDrawContext> drawContext(context->drawContext(maskTexture->asRenderTarget())); line wrap (if you care...) https://codereview.chromium.org/1404823005/diff/20001/src/gpu/GrDrawContext.cpp ...
5 years, 2 months ago (2015-10-15 14:33:04 UTC) #3
robertphillips
https://codereview.chromium.org/1404823005/diff/20001/src/effects/SkAlphaThresholdFilter.cpp File src/effects/SkAlphaThresholdFilter.cpp (right): https://codereview.chromium.org/1404823005/diff/20001/src/effects/SkAlphaThresholdFilter.cpp#newcode275 src/effects/SkAlphaThresholdFilter.cpp:275: SkAutoTUnref<GrDrawContext> drawContext(context->drawContext(maskTexture->asRenderTarget())); On 2015/10/15 14:33:04, bsalomon wrote: > line ...
5 years, 2 months ago (2015-10-15 14:40:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404823005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404823005/40001
5 years, 2 months ago (2015-10-15 14:41:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 14:48:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404823005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404823005/40001
5 years, 2 months ago (2015-10-15 15:01:06 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 15:01:52 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2e1e51f04985f7c258b96f0decc190456f5dd74d

Powered by Google App Engine
This is Rietveld 408576698