Restart the browsing data counters when the CBD dialog is opened.

Restart the browsing data counters when the CBD dialog is opened.

This is a followup to https://codereview.chromium.org/1342093003/. In that CL, we restarted the dialog on the OptionsPageUIHandler::InitializePage event, which means that the counters were restarted even if the dialog was reloaded (which doesn't trigger OptionsPageUIHandler::InitializeHandler()).

It turns out that this is not sufficient. The correct event to listen to is the Page.didShowPage in JavaScript. This is called whenever the dialog is opened, regardless of whether it happened by clicking a button, navigating directly to the page, or reloading the page.

BUG=510028
Committed: https://crrev.com/07a99474b6dd0c06b0abbf56645e24182358772c
Cr-Commit-Position: refs/heads/master@{#354266}

[msramek, 2015-10-15 11:24:04]

msramek@chromium.org changed reviewers:
+ bauerb@chromium.org

[msramek, 2015-10-15 11:24:04]

Hi Bernhard,

can you have a look?

Thanks,
Martin

[Bernhard Bauer, 2015-10-15 11:30:28]

lgtm

https://codereview.chromium.org/1404793007/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/clear_browser_data_handler.h (right):

https://codereview.chromium.org/1404793007/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/clear_browser_data_handler.h:37: void
OnPageOpened(const base::ListValue* value);
Add a comment about the parameters?

[msramek, 2015-10-15 13:54:03]

https://codereview.chromium.org/1404793007/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/clear_browser_data_handler.h (right):

https://codereview.chromium.org/1404793007/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/clear_browser_data_handler.h:37: void
OnPageOpened(const base::ListValue* value);
On 2015/10/15 11:30:28, Bernhard Bauer wrote:
> Add a comment about the parameters?

Done.

[msramek, 2015-10-15 13:54:06]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-10-15 13:54:07]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1404793007/#ps20001
(title: "Added a comment about parameters.")

[commit-bot: I haz the power, 2015-10-15 13:54:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404793007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404793007/20001

[commit-bot: I haz the power, 2015-10-15 14:58:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-15 14:59:16]

Patchset 2 (id:??) landed as
https://crrev.com/07a99474b6dd0c06b0abbf56645e24182358772c
Cr-Commit-Position: refs/heads/master@{#354266}