Decouple the browsing data counters initialization and start.

Decouple the browsing data counters initialization and start.

Previously, the counters started counting immediately after the initialization, which is called during the initialization of ClearBrowserDataHandler, and that happens immediately when chrome://settings is opened.
On the other hand, there was no trigger when the ClearBrowserDataHandler page was initialized, i.e. when chrome://settings/clearBrowserData opened.

This had two adverse effects:

- Counters started counting too soon (which is unnecessary as the user might have opened chrome://settings for any other reason)
- Reloading chrome://settings/clearBrowserData did not trigger counter restart

BUG=510028
Committed: https://crrev.com/204447a50be0272d8ed740fe25aef3c9f066a75b
Cr-Commit-Position: refs/heads/master@{#349112}

[msramek, 2015-09-15 13:21:11]

msramek@chromium.org changed reviewers:
+ bauerb@chromium.org

[msramek, 2015-09-15 13:21:11]

Hi Bernhard,

could you please have a look at this?

I'm working on data volume counters in the Clear Browsing Data dialog; I haven't
been sending you reviews about this before, but I believe that this one does not
need much context.

And, to my comfort, you're an owner for both browsing_data/ and webui/ :)

Thanks,
Martin

[Bernhard Bauer, 2015-09-15 15:04:58]

LGTM with a suggestion:

https://codereview.chromium.org/1342093003/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

https://codereview.chromium.org/1342093003/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:83: if
(AreCountersEnabled()) {
This check shouldn't reeeaally be necessary if everything goes well, because
there wouldn't be any counters anyway, right? What you could do is DCHECK it
inside of the loop.

[msramek, 2015-09-15 16:55:43]

https://codereview.chromium.org/1342093003/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

https://codereview.chromium.org/1342093003/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:83: if
(AreCountersEnabled()) {
On 2015/09/15 15:04:58, Bernhard Bauer wrote:
> This check shouldn't reeeaally be necessary if everything goes well, because
> there wouldn't be any counters anyway, right? What you could do is DCHECK it
> inside of the loop.

Of course! I added this check rather for readability purposes. I forgot that I
could DCHECK instead, thanks :-)

[msramek, 2015-09-15 16:55:45]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-09-15 16:55:45]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1342093003/#ps20001
(title: "DCHECK instead of if()")

[commit-bot: I haz the power, 2015-09-15 16:56:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342093003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342093003/20001

[commit-bot: I haz the power, 2015-09-15 17:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 17:34:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msramek, 2015-09-16 11:40:15]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-09-16 11:40:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1342093003/#ps40001
(title: "Added Restart() to tests as well.")

[commit-bot: I haz the power, 2015-09-16 11:40:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342093003/40001

[commit-bot: I haz the power, 2015-09-16 13:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 13:07:33]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[msramek, 2015-09-16 13:15:18]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-09-16 13:15:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342093003/40001

[commit-bot: I haz the power, 2015-09-16 13:42:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-16 13:43:26]

Patchset 3 (id:??) landed as
https://crrev.com/204447a50be0272d8ed740fe25aef3c9f066a75b
Cr-Commit-Position: refs/heads/master@{#349112}

[commit-bot: I haz the power, 2015-09-23 12:55:10]

Patchset 3 (id:??) landed as
https://crrev.com/204447a50be0272d8ed740fe25aef3c9f066a75b
Cr-Commit-Position: refs/heads/master@{#349112}